<font size="4"><font face="georgia,serif"><br></font></font><br><div class="gmail_quote">On Fri, Mar 16, 2012 at 11:52 PM, Jekyll Wu <span dir="ltr"><<a href="mailto:adaptee@gmail.com">adaptee@gmail.com</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">-----BEGIN PGP SIGNED MESSAGE-----<br>
Hash: SHA1<br>
<br>
Hi:<br>
<br>
    There are a few duplicated enumeration definitions scattered<br>
around within the code. They are mostly related with profile options,<br>
for example:<br>
<br>
    Profile::BellModeEnum           <==>        TerminalDisplay::BellMode<br>
    Profile::ScrollBarPositionEnum  <==><br>
TerminalDisplay::ScrollBarPosition<br>
    Profile::HistoryModeEnum        <==><br>
HistorySizeDialog::HistoryMode<br>
<br>
Such duplication is definitely not good. What is the better way to<br>
eliminate those duplication ?<br>
<br>
a). Make TerminalDisplay, HistorySizeDialog, etc all #inlucde "Profile.h"<br>
<br>
b). Move those enum definition into another separate small header(like<br>
Enumeration.h), and all other related files #include "Enumeration.h"<br>
<br></blockquote><div>Hi,</div><div>  Definitely b - also can you look at using Qt QFlags if you find that useful.</div><div><br></div><div> Thanks</div><div>   Kurt</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">


I personally prefer b).<br>
<br>
Regards<br>
Jekyll<br>
<br>
<br>
-----BEGIN PGP SIGNATURE-----<br>
Version: GnuPG v2.0.18 (GNU/Linux)<br>
Comment: Using GnuPG with Mozilla - <a href="http://enigmail.mozdev.org/" target="_blank">http://enigmail.mozdev.org/</a><br>
<br>
iQIcBAEBAgAGBQJPZApuAAoJEOemZ9znWXlA12QP/iKkbXpfZ5JIJemuv7HxFjcn<br>
xMosAZ5iuGyDJODKx+GxzeXWcn09MBdFI+HHRG6EWtCuINhfSVwoxMcspEgS+46S<br>
lcFEDd1GoMvTancymsGFkNdnyTekcLS9iGGudTS5MgjB1SKuJ94ui3OdsuQf2Xrz<br>
wgGzclywCPgLfhaX6DfQZkRqQxNI9Cbsbi8HTPb9A/RKTNK6xp+ocxory59elivn<br>
4vaJPBoVHcP+nTapIEv1sQWYBeeNemSgT+e7H5yDe9PqjMfk6Q0cwtiQQbcYkh+H<br>
7vQl03MrSyh6zFnrQ6Vo0uVLw86+QtUpEw24B2G5T9PUHH4a5fiUx6b1SkWWOPPt<br>
LfLhV/B/mog9M7MHD8li7V3/zhFcq0vKCYS1dElNJTTm7urRGtTOFTCYPRMFmcQ9<br>
xrGGswF4bEOLFgdz2VNBYEkqgY5lRZZdKuyeXOs3Iycsqe538XBbbxfDeuqtB4+w<br>
Rt9JK8Eam2OWu1GZRYFAhM4jvDMtIreIKlMy6/xZPfVDHgK0xwT9RGtllEVw2eh/<br>
xSJA5cFBUyIdZNRVqdiuicWBq7/H+uV65Q3pZWXxLsMI7EDIo+Qsnl/iNVGDpYDJ<br>
x6cyhAbD762I3TwuFbEiFuPQGhTk5OF3YzFbSfyjQKRhpntRDQa/NxTSqnCXBnyN<br>
zACzAVcw24edAVkbx1GN<br>
=o+9Z<br>
-----END PGP SIGNATURE-----<br>
_______________________________________________<br>
konsole-devel mailing list<br>
<a href="mailto:konsole-devel@kde.org">konsole-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/konsole-devel" target="_blank">https://mail.kde.org/mailman/listinfo/konsole-devel</a><br>
</blockquote></div><br>