<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104118/">http://git.reviewboard.kde.org/r/104118/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 9e8c17641e2b4dccd0bc767167d96496864f5382 by Jekyll Wu to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On February 29th, 2012, 3:25 p.m., Jekyll Wu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated Feb. 29, 2012, 3:25 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The idea is whenever a KDE3 schema(no matter whether it is official of user created) is loaded, it will be automatically saved in KDE4 colorscheme format into disk. Then next time Konsole starts, SOMENAME.colorscheme will take precedence over SOMENAME.schema. From then on, that KDE3 schema is no longer relevant to users. And that
transition should be totally transparent to users.
Using this strategy, I guess after 3 or 4 major releases, all KDE3 schemas on users' disk will be no longer relevant. Then we can remove the code for locating and reading KDE3 schemas.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/ColorSchemeManager.cpp <span style="color: grey">(f1cb33a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104118/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>