<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103949/">http://git.reviewboard.kde.org/r/103949/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 14th, 2012, 3 p.m., <b>Kurt Hindenburg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since the default is to not use %d, the user would have to select it if they want. I'm more inclined to live the code as-is.
Perhaps give some documentation about changing the defaults in the rc file would be better than nothing.</pre>
</blockquote>
<p>On February 14th, 2012, 4:18 p.m., <b>Jekyll Wu</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, I think that "%D" being default is just another hack/workaround (like this one) to reduce the impact of the reported problem.
According to the git history, "%d" has been the default until the recent commit in the bug report. I think choosing "%d" as default is a good idea, because "%D" can be easily expanded to quite long. So even we now provide "%D" as default, I doubt users will use that default happily. They will probably try "%d", and find the reported problem quickly. So I think that workaround is not that useful.
The ideal solution is to provide gui elements for controlling this feature. But I doubt the effort will pay off for this feature, or the priority is high enough. So before we finally provide a real solution, I propose to use another workaround than the current workaround. That is :
* use "%d" as default
* disable that feature by default by settings the list as empty in the code
* add good documentation on how to enable that feature by editing konsolerc manually
Yes, the proposed workaround means some (power) users who enjoy this feature might find this feature is gone in surprise. But I do believe they are the minority and are capable of finding how to get it back through reading documentation.
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm not 100% that your propose is a good idea. If we implement it, on updating konsole, can we check the users profiles and if they are using %d manually add current list to the CommonDirNames? If not, all the users using %d will be confused on what happened.
On a side note, I'm not against adding GUI for configurations options. Currently, the config dialogs are not very well organized. It would be better now that we're splitting the konsole and profile settings. Both the 'manager profile' and 'configure profile' dialogs need a revamp.</pre>
<br />
<p>- Kurt</p>
<br />
<p>On February 12th, 2012, 8:59 a.m., Jekyll Wu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated Feb. 12, 2012, 8:59 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The attached patch is only a hack, not a real solution.
I would like to discuss something:
1). In principle, shall we provide GUI for each effective option? Is it OK to have some hidden options which are only configurable through manual editing, when such options are rarely used or hard to understand for ordinary users? Of course, we must provide clear document for those hidden options in that case.
2). For this specific option, it currently always reads konsolerc, which is not quite good for konsolepart.
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=190281">190281</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/ProcessInfo.cpp <span style="color: grey">(92e3eca)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103949/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>