<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103978/">http://git.reviewboard.kde.org/r/103978/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If you can combine the 2 title change methods that'd be fine. I think it is good enough to commit.
I think 'Show shell title set by escape code on the title bar' might be a bit much and confusing. How about 'Show shell title on the title bar'?
Also, can you add docs for the new methods.
Thanks.</pre>
<br />
<p>- Kurt</p>
<br />
<p>On February 14th, 2012, 2:30 p.m., Jekyll Wu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated Feb. 14, 2012, 2:30 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The purpose is allow user to choose showing the "window title" set by escape sequence as caption indepdently upon the tab title format.
Main changes introduce
* add one gloabl option for this feature. Disabled by default, of course
* call setCaption() instead of setPlainCaption(). Now we have " - Konsole" as the ending part like in other KDE applications. I failed to see why not following the (seemingly) common convention.
* add new signal rawTitleChanged() into class SessionController. The main reason is currently signal titleChanged() is only emitted when the tab title changes. That does go well with the object of showing and updating "window title" indepdently upon tab title format.
The main possible problem with this patch is the newly added rawTitleChanged() signal. Should we add it or change the current condition for emitting the titleChanged() signal?
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use emerge, mc and vim for testing. Seems fine. No problem found when switching tab.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=162326">162326</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/MainWindow.h <span style="color: grey">(4d0d3cb)</span></li>
<li>src/MainWindow.cpp <span style="color: grey">(2881d2a)</span></li>
<li>src/SessionController.h <span style="color: grey">(7738e45)</span></li>
<li>src/SessionController.cpp <span style="color: grey">(7f31d7f)</span></li>
<li>src/ViewProperties.h <span style="color: grey">(59b06d7)</span></li>
<li>src/settings/GeneralSettings.ui <span style="color: grey">(34d936a)</span></li>
<li>src/settings/konsole.kcfg <span style="color: grey">(bc6fa9f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103978/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/103978/s/434/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/02/14/global-option_400x100.png" style="border: 1px black solid;" alt="global option" /></a>
<a href="http://git.reviewboard.kde.org/r/103978/s/435/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/02/14/mc_400x100.png" style="border: 1px black solid;" alt="An example of using mc" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>