<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103859/">http://git.reviewboard.kde.org/r/103859/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"Clone" to me would be take the tab and making an exact clone of it. This doesn't seem to do that. For example, if you change any temp parameters, they are not 'cloned'. I tested changing via qdbus and then cloning that tab.
If we do 'clone' it has to be separated from the 'Close Tab'.</pre>
<br />
<p>- Kurt</p>
<br />
<p>On February 3rd, 2012, 6:22 p.m., Jekyll Wu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated Feb. 3, 2012, 6:22 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since "New Tab" always uses default profile now, It might be helpful to add this new action dedicated for the previous handy but potentially confusing functionality.
The code is not complex. My main concern is whether it should be an action only accessible through keyboard shortcut or also accesible through menu. If accessible through menu, then the name "Clone Tab" is a bit problematic, since it is very similar to the name "Close Tab".
"Duplicate Tab" might be another choice of name, but I don't think it is as clear as "Clone Tab".</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=254976">254976</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=292518">292518</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>desktop/konsoleui.rc <span style="color: grey">(ace6bee)</span></li>
<li>src/MainWindow.h <span style="color: grey">(b3dd218)</span></li>
<li>src/MainWindow.cpp <span style="color: grey">(ab8bba6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103859/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>