<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103668/">http://git.reviewboard.kde.org/r/103668/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yea, go ahead - might as well put the parent in there. At one time I thought it was discussed to remove Shell entry in favor of the internal profile. The edit/manager dialogs would have to changed to handle that.</pre>
<br />
<p>- Kurt</p>
<br />
<p>On January 10th, 2012, 6:42 a.m., Jekyll Wu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated Jan. 10, 2012, 6:42 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently, Shell.profile contains some entries which are either useless or duplicates:
1. 'ScrollMode' and 'ScrollLineCount' are outdated and useless.
2. 'Icon', 'ColorScheme', 'LocalTabTitleFormat' etc are the duplicates of the one in 'fallback' profile. Duplicating them in Shell.profile only increases the maintenance burden without providing any benefit.
So I would suggest to remove those entries, and only keep 'Name' and 'Comment' entries. Actually, the 'Comment' entries may also be removed, but since keeping or removing it does not influence the maintenance burden, we can keep it. Maybe those 'Comment' entries are really helpful to translators.
And, maybe we should add one 'Parent' entry, thus marking the 'fallback' profile as its parent in an explicit way?
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>data/profiles/Shell.profile <span style="color: grey">(bc7faf0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103668/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>