<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102906/">http://git.reviewboard.kde.org/r/102906/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">AFAIK it looks OK. The tab issue can be looked at later. </pre>
<br />
<p>- Kurt</p>
<br />
<p>On October 18th, 2011, 4:25 p.m., Jekyll Wu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated Oct. 18, 2011, 4:25 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch is basically based upon the patch from comment #94 in bug #188528.
As noted in the code comment, the added 'isRealCharacter' boolean field can be furthur improved to become a enum field to indicate more roles:
* RealCharacter: a character which really exists
* PlaceHolderCharacter: a character which exists as place holder
* TabStopCharacter: a special place holder for HT('\t')
I think that 'TabStopCharacter' will make it possible to copy HT('\t') as it is in the future(bug #168368).
However, I have not figured out the how konsole exactly deals with HT('\t') so just leave that field as boolean for now.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I used the alpine example for testing. The result seems fine and no regressio is observed so far. If there is regression I haven't noticed, I guess it might be 'TAB'('\t') related.
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=188528">188528</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=254628">254628</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/Character.h <span style="color: grey">(56df4b4)</span></li>
<li>src/Screen.cpp <span style="color: grey">(4daa371)</span></li>
<li>src/TerminalCharacterDecoder.cpp <span style="color: grey">(1866df7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102906/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>