<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102239/">http://git.reviewboard.kde.org/r/102239/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit e3a09c9c4d7a35d458440e28501098f3ac13b684 by Jekyll Wu to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On August 26th, 2011, 2:51 p.m., Jekyll Wu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated Aug. 26, 2011, 2:51 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently, konsole kills the terminal process by sending SIGHUP and optionllay close the pty device. It is quite generic and works well with most terminal process. But it fails with some special programs.
The common root cause of those 3 bugs is: autossh, irssi and su won't die after receiving SIGHUP. The action of closing pty device does not make them die, either(which really confuses me a bit).
This patch will adds a last resort: sends SIGKILL to the terminal process, if existing way has failed.
I feel a bit worried about some implementation details in this patch: annotations, namings, public or private, timeout length, etc. So plese take it as a starting point, if the idea is OK.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have tested this patch with 3 profiles contains 'autossh -M 0:7 user@host', 'irssi' and 'su -l' as commnd, and konsole can close session created from those profiles as expected. No regression observed so far.
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=241709">241709</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=251566">251566</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=254600">254600</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/MainWindow.cpp <span style="color: grey">(507fbe3)</span></li>
<li>src/Session.h <span style="color: grey">(2060bb5)</span></li>
<li>src/Session.cpp <span style="color: grey">(a9b8490)</span></li>
<li>src/SessionController.h <span style="color: grey">(8ae33cf)</span></li>
<li>src/SessionController.cpp <span style="color: grey">(fbb8531)</span></li>
<li>src/ViewManager.cpp <span style="color: grey">(26d4270)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102239/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>