<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102742/">http://git.reviewboard.kde.org/r/102742/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks great, ship it.
Why are you considering the possibility of removing the newline? Do other terminals do that? Is someone asking for it?</pre>
<br />
<p>- Kurt</p>
<br />
<p>On September 30th, 2011, 10:15 a.m., Jekyll Wu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated Sept. 30, 2011, 10:15 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">'Select the whole line' and 'Select from mouse position to the end of line' are not a boolean pair. A checkbox is not a very good choice for easy understanding. I think that property should be of enum type and a combobox with drop-down list is a better choice.
By the way, I am considering implementing the behavior of "Select from mouse position to the end of line without the final LINEBREAK". Do you think that is a good idea? If so, should that become the third choice, or replace the exising 'Select from mouse position to the end of line'.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/EditProfileDialog.h <span style="color: grey">(3d73325)</span></li>
<li>src/EditProfileDialog.cpp <span style="color: grey">(d736a8a)</span></li>
<li>src/EditProfileDialog.ui <span style="color: grey">(fa1a70f)</span></li>
<li>src/Profile.h <span style="color: grey">(ed43ba1)</span></li>
<li>src/Profile.cpp <span style="color: grey">(eafb4dd)</span></li>
<li>src/ViewManager.cpp <span style="color: grey">(a716c4e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102742/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/102742/s/279/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/09/30/5th_2_400x100.png" style="border: 1px black solid;" alt="triple click behavior" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>