<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102685/">http://git.reviewboard.kde.org/r/102685/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit acd37f7a739ffac0863b2580c775b0956c45baa8 by Jekyll Wu to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On September 25th, 2011, 1:55 a.m., Jekyll Wu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated Sept. 25, 2011, 1:55 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is a follow up of my suggestion of putting new tab right after current tab(current behavior on master branch).
The involved logic is not complex. My main concern is the UI part. Is checkbox the right choice? I mean, technically, "putNewTabAtEnd" and "putNewTabRightAfterCurrentTab" are not a boolean pair. So is combobox a better choice? Also I think the text can be improved. Suggestions are really needed.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No problem found yet.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=276872">276872</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/EditProfileDialog.h <span style="color: grey">(46f5a60)</span></li>
<li>src/EditProfileDialog.cpp <span style="color: grey">(582bccc)</span></li>
<li>src/EditProfileDialog.ui <span style="color: grey">(4d7d175)</span></li>
<li>src/Profile.h <span style="color: grey">(7fd1f6c)</span></li>
<li>src/Profile.cpp <span style="color: grey">(6254d35)</span></li>
<li>src/ViewManager.cpp <span style="color: grey">(727b591)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102685/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/102685/s/269/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/09/23/empty-name-waring-right-below-profile-name1_400x100.png" style="border: 1px black solid;" alt="new option in EditProfileDialog" /></a>
<a href="http://git.reviewboard.kde.org/r/102685/s/273/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/09/25/utilities1_1_400x100.png" style="border: 1px black solid;" alt="use combobox instead of checkbox" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>