<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102177/">http://git.reviewboard.kde.org/r/102177/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 12th, 2011, 12:49 p.m., <b>Gu Rui</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry that my last review on this is only partly correct. The resize code is right as long as Wu's patch applied. I have investigated the code and found the code never use screenLines[lines]. cuY and _bottomMargin is never beyond lines-1(Screen::setCursorY and Screen::cursorDown and Screen::setMargins). Screen::copyFromScreen only copy the first lines of screenLines to dest.(let startLine=0 and count=lines could make it more clear)
I still think screenLines = new ImageLine[lines+1] is just to cope with lines=0. So we can at least do something with screenLines. However, if we are careful, that extra line could be eliminated.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for your investigation. I think you are right on the explanation of "screenLines = new ImageLine[lines+1];"
If nobody objects, I will commit this one-line patch sometime later. I think that would be better than current situation, and if regression is found later it can always be reverted easily.</pre>
<br />
<p>- Jekyll</p>
<br />
<p>On August 2nd, 2011, 6:51 a.m., Jekyll Wu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated Aug. 2, 2011, 6:51 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch eliminate the problem described in comment #1 of bug #192221. However, I am not sure that patch is really correct and would not cause new problems, because I do not quite understand why the Screen class always allocate spaces for N+1 lines when it is set to has N lines.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=192221">192221</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/Screen.cpp <span style="color: grey">(ecd1642)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102177/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>