<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102372/">http://git.reviewboard.kde.org/r/102372/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit d11fd4ea18de0bab408e6a41770278873d968ba4 by Jekyll Wu to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On September 17th, 2011, 6:13 p.m., Jekyll Wu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated Sept. 17, 2011, 6:13 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think this feature is quite handy in a few situations. For example, execute a couple of commands in a new tab then paste the whole output as example in a tutorial or forum post. It is not difficult to implement and gnome-terminal & xfce4-terminal both provide it, so why not?
The action use Ctrl+Shift+S as default shortcut. My first thought is using Ctrl+Shift+A, but that is already used by 'Moninor activity' action. Actually, neither of them are very convenient to press. Any idea for better default shortcut?
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It works quite well when the first screen is in use(shell, of course).
However, when the second screen is in use(less,vim,nano,mc,etc), it does not work very well. I can still use it to select all text in the screen, but copying them will return garbage result.
Maybe this action should be disabled when the second screen is used. That requires extra code in Emulation.cpp to emit some signal when the screen is switched.
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=199990">199990</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>desktop/sessionui.rc <span style="color: grey">(e9894da)</span></li>
<li>src/ScreenWindow.h <span style="color: grey">(51adb42)</span></li>
<li>src/ScreenWindow.cpp <span style="color: grey">(553b4e2)</span></li>
<li>src/SessionController.h <span style="color: grey">(0de39d4)</span></li>
<li>src/SessionController.cpp <span style="color: grey">(b357172)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102372/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>