<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102559/">http://git.reviewboard.kde.org/r/102559/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 14th, 2011, 1:45 p.m., <b>Kurt Hindenburg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is there any reason the warning message is not right underneath the profile name line? </pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, no good reason. I just personally feel the dialog looks cluttered if the warning message appears right below the profile name line, although that is really the logical place.
</pre>
<br />
<p>- Jekyll</p>
<br />
<p>On September 9th, 2011, 2:38 p.m., Jekyll Wu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated Sept. 9, 2011, 2:38 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently it is possible to save profile whose name is empty into disk. Such profile will be saved as .profile and displayed in the ManageProfilesDialog with no name. This is confusing to the users. I think such profile should never saved into disk.
The patch contain 2 changes:
1). In the EditProfileDialog, when user ask to save the profile, pop up a warningbox if its name is empty.
2). In SessionManager, when asked to apply changes to a profile, never save it into disk if its name is empty.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">works well for me so far.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=281268">281268</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/EditProfileDialog.cpp <span style="color: grey">(d1edc00)</span></li>
<li>src/EditProfileDialog.ui <span style="color: grey">(8883298)</span></li>
<li>src/SessionManager.cpp <span style="color: grey">(d782b71)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102559/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/102559/s/257/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/09/14/empty-name-waring-right-below-profile-name_400x100.png" style="border: 1px black solid;" alt="warning message right below profile name edit" /></a>
<a href="http://git.reviewboard.kde.org/r/102559/s/258/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/09/14/empty-name-waring-at-the-bottom_400x100.png" style="border: 1px black solid;" alt="warnin message at the bottom" /></a>
<a href="http://git.reviewboard.kde.org/r/102559/s/259/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/09/14/empty-name-waring-right-below-profile-name1_400x100.png" style="border: 1px black solid;" alt="warning message right below profile name line" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>