<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/4600/">http://svn.reviewboard.kde.org/r/4600/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Frank Roscher.</div>
<p style="color: grey;"><i>Updated Aug. 12, 2011, 7:20 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added a simple check to ensure the popup gets shown only for local paths - otherwise the code falls back to the old behavior of pasting the URLs as text.
This also affects other cases where we don't know the exact current path, for example screen sessions and root logins.
I'm aware this introduces an inconsistency; avoiding this would apparently require a custom popup, eliminating at least part of the advantage of using KonqOperations. The inconsistency might be acceptable seeing that Konsole has pretty advanced users, but ultimately I'm not the one to make that call. I won't be disappointed if you don't think it should be integrated like this, but I probably won't have the time to write up a patch with custom popups.
Oh, and sorry for the diff against the SVN repository. I tested against current git master, but ReviewBoard kind of didn't cooperate.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">With this patch Konsole creates a popup menu when a file from e.g. Dolphin has been dragged'n'dropped to it.
The popup menu allows to Copy, Move or Link the file into the current working directory or to simply paste its URL as text (the latter being the current behaviour in KDE4).
The popup is created using the same method that is used by dolphin, so there shouldn't be any concern about code duplication.
I'm not quite sure if this is the most elegant solution, especially with regard to my use of the sender() method. Please enlighten me if there's a better way :)
There was a (different) implementation for this back in KDE3 times; there's also a pretty popular wishlist item on the KDE forums.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">All possible operations in the popup with files and folders; local as well as over SFTP, single files as well as multiple files at once.
Dropping simple text still works, as well.
But I do tend to miss obvious stuff sometimes.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdebase/apps/konsole/src/CMakeLists.txt <span style="color: grey">(1192362)</span></li>
<li>trunk/KDE/kdebase/apps/konsole/src/SessionController.cpp <span style="color: grey">(1192362)</span></li>
<li>trunk/KDE/kdebase/apps/konsole/src/TerminalDisplay.h <span style="color: grey">(1192362)</span></li>
<li>trunk/KDE/kdebase/apps/konsole/src/TerminalDisplay.cpp <span style="color: grey">(1192362)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/4600/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://svn.reviewboard.kde.org/r/4600/s/456/"><img src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/07/11/dnd_400x100.png" style="border: 1px black solid;" alt="Popup menu" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>