<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/4200/">http://svn.reviewboard.kde.org/r/4200/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Anyone have an opinion on this?</pre>
<br />
<p>- Kurt</p>
<br />
<p>On June 1st, 2010, 5:44 p.m., Valentine Sinitsyn wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Valentine Sinitsyn.</div>
<p style="color: grey;"><i>Updated June 1, 2010, 5:44 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently, Konsole uses Shift+Up/Down/PageUp/PageDown keys internally to scroll the screen buffer and doesn't pass the appropriate keycodes to the program running in the terminal. There is nothing wrong with that, although some console programs (Midnight Commander and Screen, to name a few) may employ their own scrolling mechanisms, so they are interested in receiving these keypresses.
In order to satisfy both worlds, one can still use Shift+Up/Down/... for scrolling Konsole buffer, but only if there is anything to scroll. If there is nothing (as it would normally be with any console program with its own scrolling capabilities), keypresses should be passed unmodified to the program running in terminal.
The suggested patch implements this idea. It is compatible with both KDE 4.4.3 and trunk.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes. I'm using it on my systems for some days now.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdebase/apps/konsole/src/TerminalDisplay.cpp <span style="color: grey">(1133265)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/4200/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>