<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101721/">http://git.reviewboard.kde.org/r/101721/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole, Eike Hein, Kurt Hindenburg, and Thiago Macieira.</div>
<div>By Albert Astals Cid.</div>
<p style="color: grey;"><i>Updated June 21, 2011, 10:51 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If you want to write an e with a ring, as there is no unicode character for it, you have to use e + ring combining character, this patch makes use of the unused/unfinished feature of RE_EXTENDED_CHAR to be able of actually storing more than a quint16 in each position of the terminal without changing the code too much</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Played for it for a while, checked i can copy, paste add characters, it's stored in the history, i can have a full terminal with e with ring. Here you have a few e with ring so you can paste them to the old konsole and see how the ring is missing and see how it works once patched http://www.tsdgeos.com/filewitherings.txt</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=96536">96536</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/Character.h <span style="color: grey">(4088def)</span></li>
<li>src/Emulation.cpp <span style="color: grey">(f52f7e8)</span></li>
<li>src/Screen.h <span style="color: grey">(ba99145)</span></li>
<li>src/Screen.cpp <span style="color: grey">(41df716)</span></li>
<li>src/SessionManager.h <span style="color: grey">(ccca52b)</span></li>
<li>src/SessionManager.cpp <span style="color: grey">(0db05cd)</span></li>
<li>src/TerminalCharacterDecoder.cpp <span style="color: grey">(cd05f65)</span></li>
<li>src/TerminalDisplay.h <span style="color: grey">(61de038)</span></li>
<li>src/TerminalDisplay.cpp <span style="color: grey">(5f6478f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101721/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>