<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4292/">http://reviewboard.kde.org/r/4292/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 29th, 2010, 4:07 a.m., <b>Kurt Hindenburg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre>BUG 198175 - Fredrikh sent me a patch that enables the Blur w/o an option. Did we decide if want an option to turn this off?
Index: MainWindow.cpp
===================================================================
--- MainWindow.cpp (revision 1143496)
+++ MainWindow.cpp (working copy)
@@ -57,6 +57,12 @@
#include "ViewManager.h"
#include "ViewSplitter.h"
+#ifdef Q_WS_X11
+#include <QX11Info>
+#include <X11/Xlib.h>
+#include <X11/Xatom.h>
+#endif
+
using namespace Konsole;
static bool useTransparency()
@@ -76,6 +82,12 @@
if (useTransparency()) {
setAttribute(Qt::WA_TranslucentBackground);
setAttribute(Qt::WA_NoSystemBackground, false);
+#ifdef Q_WS_X11
+ Atom net_wm_blur_region = XInternAtom(QX11Info::display(), "_KDE_NET_WM_BLUR_BEHIND_REGION", False);
+ unsigned long region[] = { 0 };
+ XChangeProperty(QX11Info::display(), winId(), net_wm_blur_region, XA_CARDINAL, 32, PropModeReplace,
+ reinterpret_cast<const unsigned char*>(®ion), 1);
+#endif
}
// create actions for menus
</pre>
</blockquote>
<p>On June 29th, 2010, 4:08 a.m., <b>Kurt Hindenburg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre>I don't have a system that Blur works so I can't verify it works.</pre>
</blockquote>
</blockquote>
<pre>There hasn't been a decision yet on whether it should be configurable or not. I'd still go for a configuration option - it would eliminate a possible use-case of konsole's transparency otherwise I think.
What do the other Konsole people think then?</pre>
<br />
<p>- Arno</p>
<br />
<p>On June 13th, 2010, 1:57 p.m., Arno Rehn wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Arno Rehn.</div>
<p style="color: grey;"><i>Updated 2010-06-13 13:57:43</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">This patch adds an option to Konsole's color scheme editor to enable blurring on transparent backgrounds. It makes use of the new _KDE_NET_WM_BLUR_BEHIND_REGION Atom recognized by KWin.
When tabs are switched it checks whether the color scheme of the new tab has blurring enabled and enables or disables blurring accordingly.
I know we're in hard feature freeze and string freeze. But to not have this forgotten, I'll post it here now.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">Tested by switching tabs back and forth, enabling and disabling blurring again and again. No crashes so far.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/apps/konsole/src/ColorScheme.h <span style="color: grey">(1137325)</span></li>
<li>/trunk/KDE/kdebase/apps/konsole/src/ColorScheme.cpp <span style="color: grey">(1137325)</span></li>
<li>/trunk/KDE/kdebase/apps/konsole/src/ColorSchemeEditor.h <span style="color: grey">(1137325)</span></li>
<li>/trunk/KDE/kdebase/apps/konsole/src/ColorSchemeEditor.cpp <span style="color: grey">(1137325)</span></li>
<li>/trunk/KDE/kdebase/apps/konsole/src/ColorSchemeEditor.ui <span style="color: grey">(1137325)</span></li>
<li>/trunk/KDE/kdebase/apps/konsole/src/TerminalDisplay.h <span style="color: grey">(1137325)</span></li>
<li>/trunk/KDE/kdebase/apps/konsole/src/TerminalDisplay.cpp <span style="color: grey">(1137325)</span></li>
<li>/trunk/KDE/kdebase/apps/konsole/src/ViewManager.cpp <span style="color: grey">(1137325)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4292/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://reviewboard.kde.org/r/4292/s/430/"><img src="http://reviewboard.kde.org/media/uploaded/images/2010/06/13/konsole-blurring_400x100.png" style="border: 1px black solid;" alt="Konsole with enabled blurring" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>