[konsole] [Bug 372116] Feature Request: Support OSC 52 (copy to clipboard)

[Shmerl]

https://bugs.kde.org/show_bug.cgi?id=372116

--- Comment #39 from Shmerl <shtetldik at gmail.com> ---
(In reply to Christian Muehlhaeuser from comment #38)
> (In reply to Shmerl from comment #35)
> > Well, I see it being used at least in a few places in the code:
> > 
> > ```
> > src/Vt102Emulation.cpp:322:    tokenBufferPos = qMin(tokenBufferPos,
> > MAX_TOKEN_LENGTH - 1);
> > src/Vt102Emulation.h:127:#define MAX_TOKEN_LENGTH 256 // Max length of
> > tokens (e.g. window title)
> > src/Vt102Emulation.h:132:    uint tokenBuffer[MAX_TOKEN_LENGTH]; // FIXME:
> > overflow?
> > ```
> 
> That looks like an outdated version of the code. Looking at the git history,
> it seems like this issue may have been fixed a few weeks ago and the
> tokenBuffer now gets resized to fit the content. I've got to take a closer
> look, but that might enable me to revisit this issue. Either way
> MAX_TOKEN_LENGTH is definitely obsolete now.

Right, I should have clarified, I was doing it with Debian testing's konsole
which is behind recent versions (due to Debian being in the middle of time_t
64-bit migration monstrosity and KDE maintainers not updating things often).

https://tracker.debian.org/pkg/konsole

But that's regardless, if the new code isn't using that define, it's still
might have the limit somewhere. So you can get the idea what can be increased?

-- 
You are receiving this mail because:
You are the assignee for the bug.