New Defects reported by Coverity Scan for Konsole

[Tomaz Canabrava]

This one is mine, it was a crash apol got.
not bidi related.

On Fri, Sep 9, 2022 at 5:33 PM Kurt Hindenburg <kurt.hindenburg at gmail.com>
wrote:

> FYI - master today - I thought a fix went in for the bidi issues?
>
> Analysis Summary:
>      New defects found: 1
>      Defects eliminated: 0
>
> Kurt
>
> > Begin forwarded message:
> >
> > 1 new defect(s) introduced to Konsole found with Coverity Scan.
> >
> >
> > New defect(s) Reported-by: Coverity Scan
> > Showing 1 of 1 defect(s)
> >
> >
> > ** CID 356762:  Error handling issues  (CHECKED_RETURN)
> > /home/kurthindenburg/Devel/KDE/src/konsole/src/Screen.cpp: 1670 in
> Konsole::Screen::setSelectionEnd(int, int, bool)()
> >
> >
> >
> ________________________________________________________________________________________________________
> > *** CID 356762:  Error handling issues  (CHECKED_RETURN)
> > /home/kurthindenburg/Devel/KDE/src/konsole/src/Screen.cpp: 1670 in
> Konsole::Screen::setSelectionEnd(int, int, bool)()
> > 1664
> > 1665             // This should never happen, but it's happening. this
> is just to gather some information
> > 1666             // about the crash.
> > 1667             // Do not let this code go to a release.
> > 1668             if (_screenLines.size() < line) {
> > 1669                 QFile
> konsoleInfo(QStringLiteral("~/konsole_info_crash_array_out_of_bounds.txt"));
> >>>>   CID 356762:  Error handling issues  (CHECKED_RETURN)
> >>>>   Calling "open" without checking return value (as is done elsewhere
> 11 out of 12 times).
> > 1670                 konsoleInfo.open(QIODevice::WriteOnly);
> > 1671                 QTextStream messages(&konsoleInfo);
> > 1672
> > 1673                 messages << "_selBegin" << _selBegin << "\n";
> > 1674                 messages << "endPos" << endPos << "\n";
> > 1675                 messages << "_selBottomRight" << _selBottomRight <<
> "\n";
> >
> >
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20220909/cb2c626f/attachment.htm>