[konsole] [Bug 461478] Crash when entering RTL text ended with an RLM.

[Matan Ziv-Av]

https://bugs.kde.org/show_bug.cgi?id=461478

Matan Ziv-Av <matan at svgalib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Latest Commit|                            |https://invent.kde.org/util
                   |                            |ities/konsole/commit/da3b7b
                   |                            |1d0e7dc5d3894b7c111f88627b3
                   |                            |08a24d6
             Status|ASSIGNED                    |RESOLVED

--- Comment #2 from Matan Ziv-Av <matan at svgalib.org> ---
Git commit da3b7b1d0e7dc5d3894b7c111f88627b308a24d6 by Matan Ziv-Av.
Committed on 09/11/2022 at 11:30.
Pushed by hindenburg into branch 'master'.

Fix bug in Bidi mapping visual to logical positions

There are three positions for each character:
- Logical (where it is in the text, extended characters count as one)
- Visual (where it is on the screen)
- Line (where it is in the text, extended characters are expanded).

In TerminalDisplay::bidiMap, the calculation of visual to line map, used
logical instead of visual in one place. This causes using an uninitialized
memory as an index to an array, as well as other issues.

When no extended characters are used, line and logical are the same. When
no bidi characters (Arabic or Hebrew) are used, visual and logical are the
same.

M  +5    -4    src/terminalDisplay/TerminalDisplay.cpp
M  +9    -23   src/terminalDisplay/TerminalPainter.cpp
M  +2    -0    src/terminalDisplay/TerminalPainter.h

https://invent.kde.org/utilities/konsole/commit/da3b7b1d0e7dc5d3894b7c111f88627b308a24d6

-- 
You are receiving this mail because:
You are the assignee for the bug.