[konsole] [Bug 443117] "Mark taskbar entry" does not work for Konsole notifications

[Kurt Hindenburg]

https://bugs.kde.org/show_bug.cgi?id=443117

Kurt Hindenburg <kurt.hindenburg at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Latest Commit|                            |https://invent.kde.org/util
                   |                            |ities/konsole/commit/28bfbf
                   |                            |1a9fa78f79a2d17301615da4c6b
                   |                            |3afc9f3
             Status|REPORTED                    |RESOLVED

--- Comment #3 from Kurt Hindenburg <kurt.hindenburg at gmail.com> ---
Git commit 28bfbf1a9fa78f79a2d17301615da4c6b3afc9f3 by Kurt Hindenburg, on
behalf of Luis Javier Merino Morán.
Committed on 11/01/2022 at 15:57.
Pushed by hindenburg into branch 'master'.

Pass widget again to monitoring KNotifications

9f656939 introduced the possibility of showing a session in multiple
views, something which is no longer supported.  In doing so, it started
passing QApplication::activeWindow(), instead of TEWidget (nowadays
TerminalDisplay) to KNotification.

7592e894 split notifications for focused/unfocused terminals.
Unfortunately, QApplication::activeWindow() returns nothing for unmapped
windows, which results in issues when notifications are configured to
mark the task bar entry or run a command with %w/%t substitutions (for
window id and window title).

M  +12   -2    src/session/Session.cpp
M  +1    -1    src/session/SessionController.cpp

https://invent.kde.org/utilities/konsole/commit/28bfbf1a9fa78f79a2d17301615da4c6b3afc9f3

-- 
You are receiving this mail because:
You are the assignee for the bug.