[konsole] [Bug 431601] Ctrl-clicking on filenames with line numbers on the end from `grep` output has broken recently

[Kurt Hindenburg]

https://bugs.kde.org/show_bug.cgi?id=431601

Kurt Hindenburg <kurt.hindenburg at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
      Latest Commit|                            |https://invent.kde.org/util
                   |                            |ities/konsole/commit/a5f298
                   |                            |063a5a2be60a15916979ff07529
                   |                            |b61a841
         Resolution|---                         |FIXED

--- Comment #6 from Kurt Hindenburg <kurt.hindenburg at gmail.com> ---
Git commit a5f298063a5a2be60a15916979ff07529b61a841 by Kurt Hindenburg, on
behalf of Ahmad Samir.
Committed on 20/01/2021 at 15:36.
Pushed by hindenburg into branch 'master'.

FileFilterHotSpot: check the mime type of the file after cleaning the path

QMimeDataBase will return "application/octet-stream" as the mime type
of something like "path/to/some/textfile.txt:123:123:", because we are
using methods from it that check only the file extension. That meant
some valid text files with line/column suffixes couldn't be opened.

Instead move the mime type check _after_ the file path has been cleaned.
Also account for mime types that aren't recognized, e.g. a text file with
no extension.

M  +13   -7    src/filterHotSpots/FileFilterHotspot.cpp

https://invent.kde.org/utilities/konsole/commit/a5f298063a5a2be60a15916979ff07529b61a841

-- 
You are receiving this mail because:
You are the assignee for the bug.