[konsole] [Bug 411962] konsole crashes when closing a tab

[bugzilla_noreply at kde.org]

https://bugs.kde.org/show_bug.cgi?id=411962

tcanabrava at kde.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
   Version Fixed In|                            |21.12
             Status|ASSIGNED                    |RESOLVED
      Latest Commit|                            |https://invent.kde.org/util
                   |                            |ities/konsole/commit/39d343
                   |                            |7df95b4fedbafa8f09d64f9c482
                   |                            |feed551

--- Comment #12 from tcanabrava at kde.org ---
Git commit 39d3437df95b4fedbafa8f09d64f9c482feed551 by Tomaz  Canabrava, on
behalf of Ahmad Samir.
Committed on 05/08/2021 at 09:17.
Pushed by tcanabrava into branch 'master'.

Fix crash when closing a tab using the close button

Looking at the crash backtraces from the bug reports, it seems this is what
happens, when you have two tabs open, then click the close button on the
non-current tab:
  - QTabBar::currentChanged() is emitted, the TerminalDisplay pointer is
    still not null at this point (the code checks for that)
  - TabbedViewContainer::currentTabChanged()
  - TabbedViewContainer::activeViewChanged()
  - ViewManager::activateView(), at this point the TerminalDisplay pointer
    could be null, which then crashes when we call Widget::setFocus()
FIXED-IN: 21.12

M  +6    -6    src/ViewManager.cpp

https://invent.kde.org/utilities/konsole/commit/39d3437df95b4fedbafa8f09d64f9c482feed551

-- 
You are receiving this mail because:
You are the assignee for the bug.