D26744: Support opening new sessions in current working dir

[Nathaniel Graham]

ngraham added a comment.


  LGTM modulo a few nitpicks:

INLINE COMMENTS

> terminal.cpp:308
> +
> +QString Terminal::currentWorkingDirectory () const
> +{

`currentWorkingDirectory ()`

> terminal.h:32
>  
> -class TerminalInterface;
> +class TerminalInterfaceV2;
>  

Might be nice to add a comment here explaining why we're using the V2 version

> terminal.h:68
>  
> +        QString currentWorkingDirectory () const;
> +

`currentWorkingDirectory()`

REPOSITORY
  R369 Yakuake

BRANCH
  start-in-session-dir (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26744

To: muesli, hein, #yakuake, #konsole, tcanabrava, hindenburg, mweepigeon
Cc: ngraham, mweepigeon, ryanmccoskrie
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20200310/5aa07948/attachment.html>