D26439: Also copy _colorRandomization when creating a new ColorScheme from another one

[Wolfgang Bauer]

wbauer created this revision.
wbauer added a reviewer: Konsole.
Herald added a project: Konsole.
Herald added a subscriber: konsole-devel.
wbauer requested review of this revision.

REVISION SUMMARY
  The `_colorRandomization` property is new in 19.12, and should be copied by the copy constructor as well.
  
  This fixes the problem that it was not possible to disable the "Randomly adjust colors for each session" option again
  once it was enabled.

TEST PLAN
  In the color scheme editor:
  Choose "Black on Random Light" and click on Edit, disable "Randomly adjust colors for each session", and click OK.
  It's saved correctly now, previously it stayed on.
  
  Alternatively, select some other color scheme, enable the option and click OK. Then try to disable it again. This works now, previously it also stayed on.
  
  Select an existing colorscheme and click on New, the new color scheme still properly inherits "Random background" setting. (this actually worked before, which I find slightly surprising... ;-) )

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D26439

AFFECTED FILES
  src/ColorScheme.cpp

To: wbauer, #konsole
Cc: konsole-devel, cent, EspadaV8, fbampaloukas, thsurrel, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20200105/6f45aa64/attachment.html>