D27202: Add an option to set the custom color of text under the cursor

[Arthur Kasimov]

arthurk created this revision.
arthurk added reviewers: Konsole, VDG.
Herald added a project: Konsole.
Herald added a subscriber: konsole-devel.
arthurk requested review of this revision.

REVISION SUMMARY
  Current version of Konsole allows to select the custom color of the cursor (Settings -> Edit Current Profile -> Appearance -> Cursor -> Custom cursor color). This works well for I-Beam and Underline cursor shapes. But for block-shaped cursors the text under the cursor is often hard to read, e.g. bright text under the bright cursor or dark text under the dark cursor.
  
  This patch adds an ability to select the custom color of the character under the cursor. The character uses this color only when the cursor shape is Block and Konsole window is focused. Otherwise the character uses its foreground color as usual.
  
  FEATURE: 407915
  FIXED-IN: 20.04
  
  Before:
  F8089013: konsole_before.png <https://phabricator.kde.org/F8089013>
  
  After:
  F8089014: konsole_after.png <https://phabricator.kde.org/F8089014>
  
  Settings window before:
  F8089017: options_before.png <https://phabricator.kde.org/F8089017>
  
  Settings window after:
  F8089018: options_after.png <https://phabricator.kde.org/F8089018>

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D27202

AFFECTED FILES
  src/EditProfileAppearancePage.ui
  src/EditProfileDialog.cpp
  src/EditProfileDialog.h
  src/Profile.cpp
  src/Profile.h
  src/TerminalDisplay.cpp
  src/TerminalDisplay.h
  src/autotests/ProfileTest.cpp

To: arthurk, #konsole, #vdg
Cc: konsole-devel, cent, EspadaV8, fbampaloukas, thsurrel, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20200206/3b4c83fe/attachment.html>