D20816: Configure Konsole dialog GUI redesign

Björn Feber noreply at phabricator.kde.org
Sun Jun 16 09:49:16 BST 2019


GB_2 added inline comments.

INLINE COMMENTS

> MainWindow.cpp:742
> +    auto profilePage = new KPageWidgetItem(new ProfileSettings(confDialog), profilePageName);
> +    profilePage->setIcon(QIcon::fromTheme(QStringLiteral("configure")));
> +    confDialog->addPage(profilePage, true);

Please use a colorful icon like `preferences-system` here (see T10165 <https://phabricator.kde.org/T10165>).

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D20816

To: mglb, #konsole, #vdg, ngraham
Cc: GB_2, tcanabrava, ngraham, hindenburg, #vdg, konsole-devel, #konsole, cblack, arvidhansson, ian, jguidon, hannahk, Ghost6, jraleigh, fbampaloukas, squeakypancakes, alexde, IohannesPetros, trickyricky26, thsurrel, mglb, crozbo, ndavis, firef, skadinna, maximilianocuria, aaronhoneycutt, mbohlender
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20190616/31bf0c44/attachment-0001.html>


More information about the konsole-devel mailing list