[konsole] [Bug 404096] Adjust size of preferences window to eliminate unnecessary vertical scroll bar

[Kurt Hindenburg]

https://bugs.kde.org/show_bug.cgi?id=404096

Kurt Hindenburg <kurt.hindenburg at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|https://invent.kde.org/kde/ |https://commits.kde.org/kon
                   |konsole/commit/a8ec9ad28adf |sole/a8ec9ad28adfca9cb64252
                   |ca9cb64252b965c3da2d3f1a634 |b965c3da2d3f1a634b
                   |b                           |

--- Comment #6 from Kurt Hindenburg <kurt.hindenburg at gmail.com> ---
Git commit a8ec9ad28adfca9cb64252b965c3da2d3f1a634b by Kurt Hindenburg, on
behalf of Mariusz Glebocki.
Committed on 15/06/2019 at 16:52.
Pushed by scmsync into branch 'D20816'.

Configure Konsole dialog GUI redesign

Summary:
* Use custom dialog and configuraton classes, as counterparts from KF5
  are bugged. The KF5 versions should be fixed and used here.
  * Create new KConfigDialog-like class and use it to show existing
    configuration pages.
  * Create KConfigDialogManager-like class for managing QButtonGroups.

* Remove help button from configuration dialog. There is nothing about
  configuration dialog options in the help.

* Profile Settings:
  * Use QTreeView instead of QTableView - it highlights whole lines,
    aligns header names to the left, etc. Basically it looks like lists
    in file manager or e.g. plugin list in Kate.
  * Use (default) QStyledItemDelegate with checkbox instead of custom
    delegate (tick mark) in favorite/show column.
  * Change default profile item style - it now has italics font and
    "(default)" suffix.
  * Disable "Delete" button when default profile is selected
  * Use slightly extended QKeySequenceEditor. KKeySequenceWidget looks
    heavily out of place in a tree view. New editor supports some
    control keys:
    * Esc key cancels key capture.
    * Del/backspace removes shortcut.
    * Enter confirms shortcut immediately.
    * Tab/backtab commits currently edited shorcut and moves to
      next/previous shortcut.
  * Shortcuts for non visible profiles use disabled text color.
  * Note about visibility and shortcuts

* Rename "File Location" to "Temporary Files"
  * Enable path selector only when "custom" is selected
  * Place paths directly in labels

* Disable all tabbar settings except visibility when visibility is set
  to "Never"

* Minor string changes.

**Screenshots**

{F6893460}
{F6893461}
{F6893462}
{F6893463}
FIXED-IN: 19.08.0

Reviewers: #konsole, #vdg, ngraham

Reviewed By: #vdg, ngraham

Subscribers: ngraham, hindenburg, #vdg, konsole-devel, #konsole

Tags: #konsole, #vdg

Differential Revision: https://phabricator.kde.org/D20816

M  +3    -2    src/CMakeLists.txt
M  +1    -1    src/EditProfileGeneralPage.ui
M  +24   -23   src/MainWindow.cpp
A  +165  -0    src/settings/ConfigurationDialog.cpp     [License: GPL (v2+)]
A  +289  -0    src/settings/ConfigurationDialog.h     [License: GPL (v2+)]
D  +0    -41   src/settings/FileLocationSettings.cpp
D  +0    -252  src/settings/FileLocationSettings.ui
M  +272  -235  src/settings/GeneralSettings.ui
M  +173  -142  src/settings/ProfileSettings.cpp
M  +21   -15   src/settings/ProfileSettings.h
M  +122  -90   src/settings/ProfileSettings.ui
M  +10   -0    src/settings/TabBarSettings.cpp
M  +533  -198  src/settings/TabBarSettings.ui
A  +55   -0    src/settings/TemporaryFilesSettings.cpp     [License: GPL
(v2/3)]
R  +4    -4    src/settings/TemporaryFilesSettings.h [from:
src/settings/FileLocationSettings.h - 081% similarity]
A  +162  -0    src/settings/TemporaryFilesSettings.ui

https://commits.kde.org/konsole/a8ec9ad28adfca9cb64252b965c3da2d3f1a634b

-- 
You are receiving this mail because:
You are the assignee for the bug.