D21123: Compile without Q_FOREACH

Martin Tobias Holmedahl Sandsmark noreply at phabricator.kde.org
Fri Jul 5 17:52:38 BST 2019


sandsmark added a comment.


  You'll have to throw in a bunch of qAsConst() to silence clazy and the code ends up less readable imho. So I actually like Q_FOREACH better if you want to make clazy shut up as well (but in general I think clazy is a bit too triggerhappy, readable code is more important than fast code, if it is too slow you bring out a profiler and fix where the problems are).

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D21123

To: tcanabrava, #konsole, hindenburg, sandsmark
Cc: gennad, konsole-devel, fbampaloukas, thsurrel, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20190705/81ded208/attachment-0001.html>


More information about the konsole-devel mailing list