D23601: Fix the fallback code used when restoring session fails

[Jiří Paleček]

jpalecek created this revision.
jpalecek added a reviewer: hindenburg.
Herald added a project: Konsole.
Herald added a subscriber: konsole-devel.
jpalecek requested review of this revision.

REVISION SUMMARY
  When restoring session in Konsole fails, the fallback code should
   create a default view and session instead. However, the code omitted
   adding this view to the container, which makes
  
  - the window black (or grey in my case), see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=935031
  - konsole crash later, when you add a new tab and close it, because code in ViewManager expects TerminalDisplays to be children of ViewSplitter, which is not the case
  
    This fix adds the view to activeController(), just like every other code that creates TerminalDisplay.

TEST PLAN
  1. find a session in your $HOME/.config/session/ from konsole before 19.08
  2. run konsole -session xxxx (where xxxx are the numbers in your found session) -> there should be a konsole window with usable terminal
  3. add a new tab with C-S-T and close it ->there should be no crash

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D23601

AFFECTED FILES
  src/ViewManager.cpp

To: jpalecek, hindenburg
Cc: konsole-devel, fbampaloukas, thsurrel, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20190831/f9413639/attachment.html>