D12942: Remove unecessary forward-calls

[Tomaz Canabrava]

tcanabrava created this revision.
Restricted Application added a project: Konsole.
Restricted Application added a subscriber: konsole-devel.
tcanabrava requested review of this revision.

REVISION SUMMARY
  Removed some calls that the only thing it did was to forward
  with the same arguments the call to another object, call the
  object directly
  
  Do not store temporary just to do a call in the next line
  
  Do not add a new tav in every view
  
  This is a behavior change. The new tab is only in the current view
  
  Remove triplicated code
  
  Don't copy the tabs, create a new session
  
  Remove this-> used unecessarely
  
  Use the newSession from the ViewManager
  
  fourth time same code removed.
  
  Remove StackedView, use TabbedBar with Hidden Tab

TEST PLAN
  manually running konsole and testing

REPOSITORY
  R319 Konsole

BRANCH
  simplifyCode

REVISION DETAIL
  https://phabricator.kde.org/D12942

AFFECTED FILES
  src/Application.cpp
  src/MainWindow.cpp
  src/MainWindow.h
  src/ViewContainer.cpp
  src/ViewContainer.h
  src/ViewManager.cpp
  src/ViewManager.h

To: tcanabrava
Cc: konsole-devel, herrold, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180517/6342675b/attachment.html>