D13356: Fix block selection mode in a couple of cases

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> TerminalDisplay.cpp:2267
>                      extendSelection(ev->pos());
> -                } else {
> -                    _screenWindow->clearSelection();
> -
> -                    pos.ry() += _scrollBar->value();
> -                    _iPntSel = _pntSel = pos;
> -                    _actSel = 1; // left mouse button pressed but nothing selected yet.
> -                }
> -            } else {
> -                if(!_readOnly) {
> +            } else if ((!_usesMouseTracking && (ev->modifiers() & Qt::ShiftModifier) == 0u) ||
> +                       (_usesMouseTracking && (ev->modifiers() & Qt::ShiftModifier) != 0u)) {

&& !(...)

> TerminalDisplay.cpp:2268
> +            } else if ((!_usesMouseTracking && (ev->modifiers() & Qt::ShiftModifier) == 0u) ||
> +                       (_usesMouseTracking && (ev->modifiers() & Qt::ShiftModifier) != 0u)) {
> +                _screenWindow->clearSelection();

&& (...)

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D13356

To: ahmadsamir, #konsole
Cc: anthonyfieroni, konsole-devel, #konsole, herrold, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180605/1bbe5fc0/attachment-0001.html>