[Konsole-devel] Review Request 123480: Replace theme preview with a pixmap what shows all the backgrounds, consisntent with the one used for SystemSettings > Colors

[Rodrigo Fernandes]

> On April 24, 2015, 8:53 p.m., andreas kainz wrote:
> > Hi we have two discussions in the VDG about system settings.
> > 1. System setting navigation (https://community.kde.org/KDE_Visual_Design_Group/System_Settings_Application)
> > 2. Module layout
> > 
> > the Module layout HIG isn't finished yet. But the results are to have a header, description, preview and a selection area.
> > 
> > I think you made a good start to reduce the existing code and want to have an better user experience.
> > 
> > You offer an more detailed selection area. I'd prevere to have an selection area with less information (only the main color informations like background and text color) and a preview area with all informations.

Understood, makes sense.

Assuming you are too busy to do some konsole specific mockups, I can try a couple of things based on your description + the VDG. Sounds good ?


- Rodrigo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123480/#review79478
-----------------------------------------------------------


On April 23, 2015, 10:01 p.m., Rodrigo Fernandes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123480/
> -----------------------------------------------------------
> 
> (Updated April 23, 2015, 10:01 p.m.)
> 
> 
> Review request for Konsole and KDE Usability.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> Simplify theme preview
> 
> 
> Diffs
> -----
> 
>   src/EditProfileDialog.h 5fed35d 
>   src/EditProfileDialog.cpp 62b72f3 
>   src/EditProfileDialog.ui dc5af01 
> 
> Diff: https://git.reviewboard.kde.org/r/123480/diff/
> 
> 
> Testing
> -------
> 
> This patch replaces the theme preview with a similar one to System Settings > Colors.
> 
> Benefits:
>  Code reduction, lots of bespoke code removed
>  Consistency with existing ui presentation.
>  Displays the full color range as opposed to only foreground background
>  
> Drawbacks:
>  Static pixmax might not render as well in HiDPI screens.
> 
> Any feedback is greatly appreciated. 
> Please consider it for inclusion into Konsole.
> 
> Also this is my first review through RB, please mention anything I might has missed.
> 
> Regards,
>  Rodrigo
> 
> 
> File Attachments
> ----------------
> 
> Updated theme preview
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/23/5651aa87-7199-457f-b563-6c144016a06c__snapshot1.png
> 
> 
> Thanks,
> 
> Rodrigo Fernandes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20150428/872e66f0/attachment-0001.html>