[Konsole-devel] Review Request 119004: Fix crash caused by dereferencing a deleted submenu

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119004/#review61384
-----------------------------------------------------------


Aaccording to the KDE api (4.x):

KMenu * KActionMenu::menu	(		)	
Returns this action's menu as a KMenu, if it is one.
If none exists, one will be created.

Can you provide any instances where the current code actually crashes?

- Kurt Hindenburg


On June 28, 2014, 7:43 p.m., Arjun Ak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119004/
> -----------------------------------------------------------
> 
> (Updated June 28, 2014, 7:43 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> Submenu of new "newTabMenuAction" is dereferenced in multiple places without first checking whether it is null or not which can lead to a crash, especially since we delete it (https://projects.kde.org/projects/kde/applications/konsole/repository/revisions/c4f7f512f3bbd8235947defc8f3f848244d7ca1b/entry/src/MainWindow.cpp#L422) if there is only one profile to be shown.
> 
> 
> Diffs
> -----
> 
>   src/MainWindow.cpp 86d04de 
> 
> Diff: https://git.reviewboard.kde.org/r/119004/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arjun Ak
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20140701/a73021f9/attachment.html>