[Konsole-devel] Review Request 115615: Use Qt::KeyboardModifiers as the type in KeyboardTranslatorTest

Commit Hook null at kde.org
Tue Feb 11 06:33:08 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115615/#review49499
-----------------------------------------------------------


This review has been submitted with commit 8e16b55377c6fb9c6fc63f99292874a78be966fa by Martin Gräßlin to branch frameworks.

- Commit Hook


On Feb. 10, 2014, 8:01 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115615/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2014, 8:01 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> Use Qt::KeyboardModifiers as the type in KeyboardTranslatorTest
> 
> Flag types need to be declared as metatype in order to use them
> as a data type in the test. Thus it's not needed to cast to another
> type.
> 
> 
> Diffs
> -----
> 
>   src/autotests/KeyboardTranslatorTest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115615/diff/
> 
> 
> Testing
> -------
> 
> compiles and test runs successfully.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20140211/7c8950ad/attachment.html>


More information about the konsole-devel mailing list