[Konsole-devel] Review Request 110534: [ColorSchemeEditor improvements v2](part4): Add isNewScheme in ColorSchemeEditor class

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110534/#review32820
-----------------------------------------------------------


This review has been submitted with commit fae004a827ced9a1877c653c2e5a1bf2843eade0 by Kurt Hindenburg to branch master.

- Commit Hook


On May 20, 2013, 4:09 a.m., renan fargetton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110534/
> -----------------------------------------------------------
> 
> (Updated May 20, 2013, 4:09 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> Add _isNewScheme bool as private member in ColorSchemeEditor class, making the dialog aware if it correspond to a new theme or not.
> 
> At this  point it may look not very usefull, but it will become more necessary with next patch it the serie, where more stuff is moved from EditProfile into this class. Still the code is quite indepedent so I splitted it in two patches.
> 
> 
> Diffs
> -----
> 
>   src/ColorSchemeEditor.h 9b1e4b2 
>   src/ColorSchemeEditor.cpp 421f613 
>   src/EditProfileDialog.cpp f30856d 
> 
> Diff: http://git.reviewboard.kde.org/r/110534/diff/
> 
> 
> Testing
> -------
> 
> compile / run
> 
> 
> Thanks,
> 
> renan fargetton
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20130520/085c944b/attachment-0001.html>