[Konsole-devel] Save tab names in bookmarks

[Kurt Hindenburg]

Hi,
  You are more than welcomed to try not using the kdelibs bookmarking system.  If it doesn't fit Konsole's needs (and I would say it doesn't), we can use anything else.  I really never cared for the GUI with the  'edit bookmarks'.  

Thanks,
   Kurt

On Aug 4, 2013, at 1:45 PM, Lucas Betschart <lucasbetschart at gmail.com> wrote:

> Hi Kurt
> 
> Thanks for the answer.
> 
> Right know it looks like I still would have to make many changes to the KBookmark app / lib, which they probably don't like.
> 
> How do you think would be the reaction if Konsole uses it's own bookmark system without using KBookmark?
> I mean reusing code and trying to use the same UI is generally good, but I'd say the cons outweigh the pros. As every application needs some other extra stuff to save in their bookmarks, I don't think a general app is a good solution.
> Also Kate, Marble and Dolphin (with places) already use their own bookmark system (and maybe more, just checked those). The only app I know is using KBookmark is Konversation.
> 
> Regards
> Lucas
> 
> 
> 
> 2013/8/3 Kurt Hindenburg <kurt.hindenburg at gmail.com>
> Hi, we might as well have this conversation via the bko.  I'll respond here though.  It has been ages since I looked at the bookmark stuff.  However, if you want to use the Comment section I would go ahead and try it.   I have always disliked the bookmark system and the GUI isn't that useful for Konsole bookmarks.
>  You can put any patches up on git.reviewboard.kde.org under konsole group or attach them to the bko.
> 
> Thanks for your efforts,
>    Kurt
> 
> 
> On Jul 28, 2013, at 12:33 PM, Lucas Betschart <lucasbetschart at gmail.com> wrote:
> 
>> Hi guys
>> 
>> I'm trying to fix that bug / feature: https://bugs.kde.org/show_bug.cgi?id=316110 (The names of the tabs are not bookmarked)
>> That's the first time I look at the Konsole code and I'm also quite new to KDE development (just a few minor patches to KTp months ago).
>> 
>> So far I've made a few changes that the tab name will always be set to the bookmarks name (fix). Thats not what I want to have as an end result, since probably most people want to keep it the way it is now.
>> Now I'd like to save the tab name as an extra field when adding a new bookmark. But since the Bookmark Editor (an external app) is not used only by Konsole they probably wont accept a patch that adds an such a tab name field.
>> A possible solution would be to use the "Comment"-field, but that would be a misuse of it.
>> 
>> Any suggestions what I should do?
>> 
>> Thanks for your help
>> 
>> Regards
>> Lucas
>> _______________________________________________
>> konsole-devel mailing list
>> konsole-devel at kde.org
>> https://mail.kde.org/mailman/listinfo/konsole-devel
> 
> _
> Kurt Hindenburg
> kurt.hindenburg at gmail.com
> 
> 
> 
> 
> 

_
Kurt Hindenburg
kurt.hindenburg at gmail.com




-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20130804/817e7c07/attachment.html>