[Konsole-devel] Review Request: Make using bold fonts for intense colors user-configurable

[Robert Knight]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4201/#review5940
-----------------------------------------------------------


Approach looks good.  Unfortunately it looks like there are a lot of changes in the EditProfileSettings.ui file which are unrelated to the actual change (eg. the dialog got much wider) - my guess is that this comes from Qt Designer.  Can you take the EditProfileSettings.ui from before your changes and then copy over the relevant bit from after the edits in designer?

- Robert


On 2010-06-01 18:00:16, Valentine Sinitsyn wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4201/
> -----------------------------------------------------------
> 
> (Updated 2010-06-01 18:00:16)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> It is well known that standard ANSI color codes don't distinguish between bold [font] and bright/intense [color], since both of them are controlled with a single escape command (m). In KDE3, Konsole was interpreting this command as "make the color bright" and leaving font weight untouched. Beginning with KDE4, both color and font weight are changed. At the very end, the decision whether or not to make the font bold is somewhat matter of taste, and since many fonts available for Linux look ugly when they are bold, it is reasonable to leave this decision to the user, making this a configurable runtime option.
> 
> The patch suggested add such option to the Appearance tab in Edit Profile dialog. This is a per-profile setting which defaults to "make fonts bold" for compatibility reasons.
> 
> 
> This addresses bug 226308.
>     https://bugs.kde.org/show_bug.cgi?id=226308
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/apps/konsole/src/EditProfileDialog.ui 1133265 
>   trunk/KDE/kdebase/apps/konsole/src/EditProfileDialog.cpp 1133265 
>   trunk/KDE/kdebase/apps/konsole/src/EditProfileDialog.h 1133265 
>   trunk/KDE/kdebase/apps/konsole/src/Profile.h 1133265 
>   trunk/KDE/kdebase/apps/konsole/src/Profile.cpp 1133265 
>   trunk/KDE/kdebase/apps/konsole/src/TerminalDisplay.h 1133265 
>   trunk/KDE/kdebase/apps/konsole/src/TerminalDisplay.cpp 1133265 
>   trunk/KDE/kdebase/apps/konsole/src/ViewManager.cpp 1133265 
> 
> Diff: http://reviewboard.kde.org/r/4201/diff
> 
> 
> Testing
> -------
> 
> Yes. Works with KDE 4.4.3 and trunk on my systems
> 
> 
> Thanks,
> 
> Valentine
> 
>