[Konsole-devel] [Bug 172042] Konsole window resizes on new tab to last resized window

David Faure faure at kde.org
Tue Oct 14 20:05:05 UTC 2008


http://bugs.kde.org/show_bug.cgi?id=172042





--- Comment #17 from David Faure <faure kde org>  2008-10-14 22:05:03 ---
I see what you mean, but the naming of the variables is really strange. If I
start an application in KDE, getting d->isSessionRestored = true; is really
strange. I think isRestored should be sizeApplied, and, hmm the logic around
isSessionRestored needs some cleanup. Right now it's a hack that says "call
restoreWindowSize twice", basically (once with isSessionRestored=false and once
with isSessionRestored=true). But I think this breaks in apps using kparts, if
the gui is built in two stages (app+part) before we get to the session
management restoration. This could be cleaned up by using the fact that
readPropertiesInternal is the one called by session management restoration.

Yeah, I think it could work with a single bool sizeApplied, false initially,
true after calling restoreWindowSize, and reset to false in
readPropertiesInternal in order to force applyMainWindowSettings to apply the
size again (because it comes from a different config file, that's the
point...).


-- 
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the konsole-devel mailing list