<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/130236/">https://git.reviewboard.kde.org/r/130236/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 29th, 2017, 3:27 p.m. UTC, <b>Jack Ostroff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please clarify - this makes the qt4 and qt5 versions of libalkimia co-installable. Is that only if both are the same version, or is it also true if you compile libalkimia 5.0.0 (released) with qt4 and 6.0.0 (from git) with qt5? KMyMoney 4.8 requires <6.0 and KMyMoney 5.0 (git head) requires >=6.0. The latest change goes to 7.0.0 (was there ever a 6.0.0?) which cannot be used by KMM 4.8.x although it is still mentioned.</pre>
</blockquote>
<p>On August 29th, 2017, 3:50 p.m. UTC, <b>Ralf Habacker</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Is that only if both are the same version,
yes version 7.0.0 unified qt4 and qt5 builds to one source.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">or is it also true if you compile libalkimia 5.0.0 (released) with qt4 and 6.0.0 (from git) with qt5?
no, libalkimia 5.0 (qt4 only) and 6.0 (qt5 only) uses the same include header path and library names</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">KMyMoney 4.8 requires <6.0 and KMyMoney 5.0 (git head) requires >=6.0.
Is this only because of alkimia build system issues or are there any code changes involved ? In case of the first, the are no problems with this patch. </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The latest change goes to 7.0.0 </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">(was there ever a 6.0.0?)
git tag shows 5.0.0 as the last one, so no </p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">CMakeLists specifies 6.0.90 as current version, the next stable version would be 6.1.0 - is that acceptable ? Or simply using 6.0.0 as public release ?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I think I see what I was missing. </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Version 5.0.0 was qt4 only, version 6.0.90 was qt5 only, and now you are allowing both qt versions for a single alkimia version. (Correct me if I'm still not right.)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I have no objection to that, although I don't think there will be much future use for qt4. However, out of curiosity, if qt5 was the only reason KMM 4.8 would not work with alkimia 6, then would KMM 4.8 work with the qt4 version of alikimia 7? </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm OK with jumping to 7 because of this switch, although 6.1 would also be OK. I would probably skip 6.0.0 just to avoid decreasing the version number, even if nobody used it when pulling a git version.</p></pre>
<br />
<p>- Jack</p>
<br />
<p>On August 29th, 2017, 2:06 p.m. UTC, Ralf Habacker wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KMymoney and Skrooge.</div>
<div>By Ralf Habacker.</div>
<p style="color: grey;"><i>Updated Aug. 29, 2017, 2:06 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
alkimia
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The installed package is coinstallable with the Qt5 variant.
See README.md for more details how to use.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Required for building stable kmymoney releases, which are Qt4 based.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">REVIEW:130236</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">compiled for qt4 and qt5</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">used to build with kmymoney4 and kmymoney/KF5</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">installation gives install tree for qt4:
tmp/usr/local/include/alkimia/Qt4/alkimia/alkcompany.h
tmp/usr/local/include/alkimia/Qt4/alkimia/alkvalue.h
tmp/usr/local/include/alkimia/Qt4/alkimia/alk_export.h
tmp/usr/local/include/alkimia/Qt4/alkimia/alkquoteitem.h
tmp/usr/local/lib64/libalkimia.so
tmp/usr/local/lib64/libalkimia.so.7
tmp/usr/local/lib64/libalkimia.so.7.0.90
tmp/usr/local/lib64/pkgconfig/libalkimia.pc
tmp/usr/local/lib64/cmake/LibAlkimia-7.0
tmp/usr/local/lib64/cmake/LibAlkimia-7.0/LibAlkimiaConfig.cmake
tmp/usr/local/lib64/cmake/LibAlkimia-7.0/LibAlkimiaTargets-noconfig.cmake
tmp/usr/local/lib64/cmake/LibAlkimia-7.0/LibAlkimiaConfigVersion.cmake
tmp/usr/local/lib64/cmake/LibAlkimia-7.0/LibAlkimiaTargets.cmake
tmp/usr/local/lib64/cmake/LibAlkimia-7.0/FindGMP.cmake</p>
</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">file content of libalkimia.pc</p>
</li>
</ul>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">pkg-config configuration for libalkimia</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">For information about the syntax, see pkg-config(1)</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">General installation directories</h1>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">prefix=/usr/local
exec_prefix=/usr/local
libdir=
includedir=include/alkimia/Qt4</p>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Human-readable name</h1>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Name: Alkimia</p>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Human-readable description</h1>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Description: A library for financial data handling
Version: 7.0.90</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Libs: -lalkimia
Libs.private: -lgmp -lQtCore -lQtDBus -lstdc++
Cflags: -I${includedir}</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">installation gives install tree for qt5:
tmp/usr/local/include/alkimia/Qt5/alkimia/alkcompany.h
tmp/usr/local/include/alkimia/Qt5/alkimia/alkvalue.h
tmp/usr/local/include/alkimia/Qt5/alkimia/alk_export.h
tmp/usr/local/include/alkimia/Qt5/alkimia/alkquoteitem.h
tmp/usr/local/lib64/libalkimia5.so
tmp/usr/local/lib64/libalkimia5.so.7
tmp/usr/local/lib64/libalkimia5.so.7.0.90
tmp/usr/local/lib64/pkgconfig/libalkimia5.pc
tmp/usr/local/lib64/cmake/LibAlkimia5-7.0/LibAlkimia5Config.cmake
tmp/usr/local/lib64/cmake/LibAlkimia5-7.0/LibAlkimia5Targets.cmake
tmp/usr/local/lib64/cmake/LibAlkimia5-7.0/LibAlkimia5ConfigVersion.cmake
tmp/usr/local/lib64/cmake/LibAlkimia5-7.0/LibAlkimia5Targets-noconfig.cmake
tmp/usr/local/lib64/cmake/LibAlkimia5-7.0/FindGMP.cmake</p>
</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">file content of libalkimia5.pc</p>
</li>
</ul>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">pkg-config configuration for libalkimia</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">For information about the syntax, see pkg-config(1)</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">General installation directories</h1>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">prefix=/usr/local
exec_prefix=/usr/local
libdir=
includedir=include/alkimia/Qt5</p>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Human-readable name</h1>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Name: Alkimia</p>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Human-readable description</h1>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Description: A library for financial data handling
Version: 7.0.90</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Libs: -lalkimia5
Libs.private: -lgmp -lQt5Core -lQt5DBus -lstdc++
Cflags: -I${includedir}</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(19f3e4d367324841e12b426ae9cadc127aa0e597)</span></li>
<li>README.md <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/CMakeLists.txt <span style="color: grey">(faa9973d750503cb5ef017c70a0b4a29181ab5dd)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(9765cf7c43e5c09fe20c7a6ac1b872718eeac781)</span></li>
<li>src/LibAlkimiaConfig.cmake.in <span style="color: grey">(cce2f7c420109d981f21866b0ed57bdf7ae834f8)</span></li>
<li>src/libalkimia.pc.in <span style="color: grey">(871e3f30ac0ead437b84707506d3b8d770d9f007)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/130236/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>