<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/130143/">https://git.reviewboard.kde.org/r/130143/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 4th, 2017, 11:03 a.m. CEST, <b>Christian David</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Here are some things that came to my mind while reading through this review request. Unfortunatly I cannot try the patch because I cannot compile the 4.8 branch.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What happens if the user creates a new account (no opening balances account) and enters a opening balance and there is no opening balances account, yet? Is a opening balance account created (silently)? The user can rename it later then (less user interaction, so this is my preferred behavior).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What if the user creates a opening balances account with a opening balance?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 2em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">kmymoney creates silently an opening balance account if a new account with an opening balance is added but ...
it does not flag the opening balance account to be an opening balance account. I need to fix that</p>
</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The new account dialog does not show the checkbox to specify this account to be an opening balance account so there is no issue here.</p>
</li>
</ol></pre>
<br />
<p>- Ralf</p>
<br />
<p>On May 30th, 2017, 9:45 a.m. CEST, Ralf Habacker wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Ralf Habacker.</div>
<p style="color: grey;"><i>Updated May 30, 2017, 9:45 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=370290">370290</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch introduce a feature to specify a dedicated account
to be used as opening balance account instead of using an account
with a predefined name which may be language specific.
The "opening balance account" flag could be set in the account
editor if no other account contains this flag. Also changing
the state of the flag is only possible if no transactions are
assigned to the account having this flag.
On creating a new kmymoney file the "opening balance account"
flag is imported from a related template account flag if specified
in the following form
<account type="16" name="9000 Saldovortragskonten">
<flag name="OpeningBalanceAccount" value="1"/>
</account>
If specified the template admin needs to make sure that only one
template account has this flag set.
Exporting the current kmymoney file to an account template exports
this flag too.
BUG:370290</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">compiled</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">set/unset "opening balance account" flag in account editor for a given account and save/load kmymoney file -> state is persistent</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">checked if it is possible to set "opening balance account" flag in an additional account -> check box is not visible on editing the second account</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">checked if it is possible to change "opening balance account" flag if transactions are assigned to the opening balance account -> check box is disabled</li>
</ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Note: I choosed the flag name as to be 'OpeningBalanceAccount' in the template file and kmymoney file to have the same name.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/converter/mymoneytemplate.cpp <span style="color: grey">(25a343e3fbdd9409ebdbd814bc08122c151a09d9)</span></li>
<li>kmymoney/dialogs/knewaccountdlg.cpp <span style="color: grey">(dfe2967174bf323d9eda4983fd545d0930a9ec43)</span></li>
<li>kmymoney/dialogs/knewaccountdlgdecl.ui <span style="color: grey">(bee638d2b4f73bc8496c86bbf606bfaa5fa4c913)</span></li>
<li>kmymoney/mymoney/mymoneyfile.cpp <span style="color: grey">(692014b21ec8bff4e4c3f3f240d377cd7b9697b3)</span></li>
<li>kmymoney/mymoney/storage/mymoneystorageanon.cpp <span style="color: grey">(b6d0dc6a7b499aa45498cb76bef836731ff618d4)</span></li>
<li>kmymoney/reports/objectinfotable.cpp <span style="color: grey">(584a9a378d37d51766e551d8e6b6baffe4fb397d)</span></li>
<li>kmymoney/reports/reportstestcommon.h <span style="color: grey">(22000165dff793c5d7281072f702e0ca3c40f882)</span></li>
<li>kmymoney/reports/reportstestcommon.cpp <span style="color: grey">(40b103ca965e0a1973b6fd0a351ddb976aa10471)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/130143/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>