<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/130009/">https://git.reviewboard.kde.org/r/130009/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On Juni 4th, 2017, 11:36 vorm. CEST, <b>Christian David</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I suggest to discard this review request. Mainly because I do not think that we will write the long text <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">qCDebug(LOG_KMYMONEY)</code> in future. Maybe we can use this for some submodules of KMyMoney in future.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Btw: For what do you need or want this?</p></pre>
<br />
<p>- Christian</p>
<br />
<p>On März 13th, 2017, Mittag CET, José Arthur Benetasso Villanova wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KMymoney and José Arthur Benetasso Villanova.</div>
<div>By José Arthur Benetasso Villanova.</div>
<p style="color: grey;"><i>Updated März 13, 2017, Mittag</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Use qCDebug instead of qDebug</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">For now just compiled</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/CMakeLists.txt <span style="color: grey">(585c7d4)</span></li>
<li>kmymoney/converter/existingtransactionmatchfinder.cpp <span style="color: grey">(7bedd28)</span></li>
<li>kmymoney/converter/mymoneygncreader.cpp <span style="color: grey">(4c6d28c)</span></li>
<li>kmymoney/converter/mymoneyqifreader.cpp <span style="color: grey">(3ad6723)</span></li>
<li>kmymoney/converter/mymoneyqifwriter.cpp <span style="color: grey">(da796a3)</span></li>
<li>kmymoney/converter/mymoneystatementreader.cpp <span style="color: grey">(825b490)</span></li>
<li>kmymoney/converter/scheduledtransactionmatchfinder.cpp <span style="color: grey">(4713a2b)</span></li>
<li>kmymoney/converter/tests/converter-test.cpp <span style="color: grey">(3b596ee)</span></li>
<li>kmymoney/converter/transactionmatchfinder.cpp <span style="color: grey">(56e97dd)</span></li>
<li>kmymoney/converter/webpricequote.cpp <span style="color: grey">(15b1467)</span></li>
<li>kmymoney/dialogs/kgeneratesqldlg.cpp <span style="color: grey">(5d20c1d)</span></li>
<li>kmymoney/dialogs/kselectdatabasedlg.cpp <span style="color: grey">(c281fc8)</span></li>
<li>kmymoney/kmymoney.h <span style="color: grey">(dd37972)</span></li>
<li>kmymoney/kmymoney.cpp <span style="color: grey">(674f251)</span></li>
<li>kmymoney/kmymoneyutils.cpp <span style="color: grey">(0492578)</span></li>
<li>kmymoney/logging.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/logging.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/main.cpp <span style="color: grey">(77d68a7)</span></li>
<li>kmymoney/models/accountsmodel.cpp <span style="color: grey">(12aac8d)</span></li>
<li>kmymoney/models/costcentermodel.cpp <span style="color: grey">(ac2d671)</span></li>
<li>kmymoney/models/ledgermodel.cpp <span style="color: grey">(47e7b06)</span></li>
<li>kmymoney/models/modeltest.cpp <span style="color: grey">(225e5de)</span></li>
<li>kmymoney/models/payeesmodel.cpp <span style="color: grey">(35ff045)</span></li>
<li>kmymoney/mymoney/CMakeLists.txt <span style="color: grey">(33b6177)</span></li>
<li>kmymoney/mymoney/mymoneyfile.h <span style="color: grey">(2494af3)</span></li>
<li>kmymoney/mymoney/mymoneyfile.cpp <span style="color: grey">(d39a1d6)</span></li>
<li>kmymoney/mymoney/mymoneyforecast.cpp <span style="color: grey">(b286a85)</span></li>
<li>kmymoney/mymoney/onlinejobadministration.cpp <span style="color: grey">(d5f44f6)</span></li>
<li>kmymoney/mymoney/storage/mymoneystoragesql.cpp <span style="color: grey">(4a68175)</span></li>
<li>kmymoney/mymoney/storage/tests/mymoneydatabasemgr-test.cpp <span style="color: grey">(dbaf6d0)</span></li>
<li>kmymoney/mymoney/tests/mymoneymoney-test.cpp <span style="color: grey">(ef1dd26)</span></li>
<li>kmymoney/mymoney/tests/mymoneyschedule-test.cpp <span style="color: grey">(5c911fe)</span></li>
<li>kmymoney/mymoney/tests/mymoneytransaction-test.cpp <span style="color: grey">(f6d52c6)</span></li>
<li>kmymoney/plugins/CMakeLists.txt <span style="color: grey">(6b235fb)</span></li>
<li>kmymoney/plugins/csvexport/CMakeLists.txt <span style="color: grey">(454d7d2)</span></li>
<li>kmymoney/plugins/csvexport/csvwriter.cpp <span style="color: grey">(83365bb)</span></li>
<li>kmymoney/plugins/csvimport/csvwizard.cpp <span style="color: grey">(e9ca8a6)</span></li>
<li>kmymoney/plugins/icalendarexport/CMakeLists.txt <span style="color: grey">(e30245f)</span></li>
<li>kmymoney/plugins/icalendarexport/schedulestoicalendar.cpp <span style="color: grey">(ed14916)</span></li>
<li>kmymoney/plugins/kbanking/mymoneybanking.cpp <span style="color: grey">(3e2f25b)</span></li>
<li>kmymoney/plugins/ofximport/dialogs/CMakeLists.txt <span style="color: grey">(b913db8)</span></li>
<li>kmymoney/plugins/ofximport/dialogs/kofxdirectconnectdlg.cpp <span style="color: grey">(2ddbb39)</span></li>
<li>kmymoney/plugins/ofximport/dialogs/mymoneyofxconnector.cpp <span style="color: grey">(cff2ed9)</span></li>
<li>kmymoney/plugins/onlinejobpluginmockup/onlinejobpluginmockup.cpp <span style="color: grey">(83be16e)</span></li>
<li>kmymoney/plugins/reconciliationreport/CMakeLists.txt <span style="color: grey">(b28dc02)</span></li>
<li>kmymoney/plugins/reconciliationreport/reconciliationreport.cpp <span style="color: grey">(ee2d42f)</span></li>
<li>kmymoney/reports/kreportchartview.cpp <span style="color: grey">(d1f0c51)</span></li>
<li>kmymoney/reports/pivottable.cpp <span style="color: grey">(833dc45)</span></li>
<li>kmymoney/reports/querytable.cpp <span style="color: grey">(4d5a843)</span></li>
<li>kmymoney/reports/reporttable.cpp <span style="color: grey">(1acec56)</span></li>
<li>kmymoney/reports/tests/reportstestcommon.cpp <span style="color: grey">(f64d3b6)</span></li>
<li>kmymoney/tests/kmymoneyutils-test.h <span style="color: grey">(3faac41)</span></li>
<li>kmymoney/views/kforecastview.cpp <span style="color: grey">(13c8b1a)</span></li>
<li>kmymoney/views/kmymoneyview.cpp <span style="color: grey">(91750fa)</span></li>
<li>kmymoney/views/konlinejoboutbox.cpp <span style="color: grey">(0708346)</span></li>
<li>kmymoney/views/kpayeesview.cpp <span style="color: grey">(fbe6fd0)</span></li>
<li>kmymoney/views/kreportsview.cpp <span style="color: grey">(a98d5b8)</span></li>
<li>kmymoney/views/ktagsview.cpp <span style="color: grey">(f361a4b)</span></li>
<li>kmymoney/views/ledgerdelegate.cpp <span style="color: grey">(7274966)</span></li>
<li>kmymoney/views/ledgerview.cpp <span style="color: grey">(8807d40)</span></li>
<li>kmymoney/views/newspliteditor.cpp <span style="color: grey">(707117a)</span></li>
<li>kmymoney/views/newtransactioneditor.cpp <span style="color: grey">(b7f070d)</span></li>
<li>kmymoney/views/simpleledgerview.cpp <span style="color: grey">(6793fdf)</span></li>
<li>kmymoney/views/splitdelegate.cpp <span style="color: grey">(510d55f)</span></li>
<li>kmymoney/views/splitdialog.cpp <span style="color: grey">(becdfcf)</span></li>
<li>kmymoney/widgets/CMakeLists.txt <span style="color: grey">(7560682)</span></li>
<li>kmymoney/widgets/kmymoneymvccombo.cpp <span style="color: grey">(29e378f)</span></li>
<li>kmymoney/widgets/transaction.cpp <span style="color: grey">(4061ae2)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/130009/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>