<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129082/">https://git.reviewboard.kde.org/r/129082/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been discarded.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Łukasz Wojniłowicz.</div>
<p style="color: grey;"><i>Updated Lut 3, 2017, 6:09 po południu</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch does what it's intended to do, but I'm not completly satisfied with it.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I wonder why I get lots of errors of this type
./kmymoney/kmymoney/plugins/csvimport/tests/symbol-test.cpp:34: undefined reference to `Parse::Parse()'</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">if I use <strong style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">kmm_csvimport</strong> instead of <strong style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">csvimport_tests</strong> in code block below</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span></span>file(GLOB tests_sources "*-test.cpp")
ecm_add_tests(<span style="color: #BC7A00">${</span>tests_sources<span style="color: #BC7A00">}</span>
NAME_PREFIX
"csvimport-"
LINK_LIBRARIES
Qt5::Test
csvimport_tests
)
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">if <strong style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">kmm_csvimport</strong> is <strong style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">MODULE</strong> instead of <strong style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">STATIC</strong>.
Can somebody explain it to me and knows how to do it without <strong style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">csvimport_tests</strong>?</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/plugins/csvimport/tests/CMakeLists.txt <span style="color: grey">(f5b148e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129082/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>