<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129862/">https://git.reviewboard.kde.org/r/129862/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Łukasz Wojniłowicz.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">KMM icons look properly only if oxygen icon theme is set globally. Tango
and hicolor themes aren't used at all.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch introduces settings page which allows setting icon theme
(system, oxygen or Tango) only for KMM and independently from global
setting. It also makes use of hicolor and Tango theme. Look of KMM is
more complete on icon themes different from oxygen.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">DesktopIcon function has been replaced, because it hadn't respect
QIcon::setThemeName.
Tango icons names has been adjusted to hicolor names and are used as
fallback icons to oxygen names.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested KMM with Tango, oxygen and locally installed icon theme.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/dialogs/settings/CMakeLists.txt <span style="color: grey">(72d4e1a)</span></li>
<li>kmymoney/dialogs/settings/ksettingsicons.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/dialogs/settings/ksettingsicons.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/dialogs/settings/ksettingsiconsdecl.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/dialogs/settings/ksettingskmymoney.cpp <span style="color: grey">(05759f8)</span></li>
<li>kmymoney/icons/CMakeLists.txt <span style="color: grey">(3af9f4d)</span></li>
<li>kmymoney/icons/Tango/128x128/actions/128-actions-account-types_asset.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/128x128/actions/128-actions-account-types_cash.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/128x128/actions/128-actions-account-types_checking.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/128x128/actions/128-actions-account-types_closed.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/128x128/actions/128-actions-account-types_credit-card.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/128x128/actions/128-actions-account-types_expense.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/128x128/actions/128-actions-account-types_income.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/128x128/actions/128-actions-account-types_investments.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/128x128/actions/128-actions-account-types_liability.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/128x128/actions/128-actions-account-types_loan.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/128x128/actions/128-actions-account-types_savings.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/128x128/actions/128-actions-account_add.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/128x128/actions/128-actions-forcast.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/128x128/actions/128-actions-institution_add.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/128x128/actions/128-actions-institutions.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/128x128/actions/128-actions-investments.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/128x128/actions/128-actions-onlinebanking.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/128x128/actions/128-actions-transaction_find.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/16x16/actions/16-actions-account-types_asset.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/16x16/actions/16-actions-account-types_cash.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/16x16/actions/16-actions-account-types_checking.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/16x16/actions/16-actions-account-types_closed.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/16x16/actions/16-actions-account-types_credit-card.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/16x16/actions/16-actions-account-types_expense.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/16x16/actions/16-actions-account-types_income.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/16x16/actions/16-actions-account-types_investments.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/16x16/actions/16-actions-account-types_liability.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/16x16/actions/16-actions-account-types_loan.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/16x16/actions/16-actions-account-types_savings.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/16x16/actions/16-actions-account_add.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/16x16/actions/16-actions-close_window.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/16x16/actions/16-actions-forcast.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/16x16/actions/16-actions-hide_categories.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/16x16/actions/16-actions-hide_reconciled.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/16x16/actions/16-actions-institution_add.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/16x16/actions/16-actions-institutions.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/16x16/actions/16-actions-investments.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/16x16/actions/16-actions-onlinebanking.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/16x16/actions/16-actions-personal_data.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/16x16/actions/16-actions-split_transaction.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/16x16/actions/16-actions-transaction_find.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/16x16/actions/16-actions-view_info.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/22x22/actions/22-actions-account-types_asset.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/22x22/actions/22-actions-account-types_cash.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/22x22/actions/22-actions-account-types_checking.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/22x22/actions/22-actions-account-types_closed.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/22x22/actions/22-actions-account-types_credit-card.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/22x22/actions/22-actions-account-types_expense.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/22x22/actions/22-actions-account-types_income.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/22x22/actions/22-actions-account-types_investments.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/22x22/actions/22-actions-account-types_liability.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/22x22/actions/22-actions-account-types_loan.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/22x22/actions/22-actions-account-types_savings.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/22x22/actions/22-actions-account_add.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/22x22/actions/22-actions-close_window.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/22x22/actions/22-actions-forcast.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/22x22/actions/22-actions-hide_categories.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/22x22/actions/22-actions-hide_reconciled.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/22x22/actions/22-actions-institution_add.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/22x22/actions/22-actions-institutions.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/22x22/actions/22-actions-investments.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/22x22/actions/22-actions-onlinebanking.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/22x22/actions/22-actions-personal_data.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/22x22/actions/22-actions-transaction_find.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/22x22/actions/22-actions-view_info.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/32x32/actions/32-actions-account-types_asset.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/32x32/actions/32-actions-account-types_cash.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/32x32/actions/32-actions-account-types_checking.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/32x32/actions/32-actions-account-types_closed.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/32x32/actions/32-actions-account-types_credit-card.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/32x32/actions/32-actions-account-types_expense.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/32x32/actions/32-actions-account-types_income.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/32x32/actions/32-actions-account-types_investments.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/32x32/actions/32-actions-account-types_liability.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/32x32/actions/32-actions-account-types_loan.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/32x32/actions/32-actions-account-types_savings.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/32x32/actions/32-actions-account_add.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/32x32/actions/32-actions-forcast.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/32x32/actions/32-actions-institution_add.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/32x32/actions/32-actions-institutions.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/32x32/actions/32-actions-investments.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/32x32/actions/32-actions-onlinebanking.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/32x32/actions/32-actions-transaction_find.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/48x48/actions/48-actions-account-types_asset.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/48x48/actions/48-actions-account-types_cash.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/48x48/actions/48-actions-account-types_checking.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/48x48/actions/48-actions-account-types_closed.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/48x48/actions/48-actions-account-types_credit-card.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/48x48/actions/48-actions-account-types_expense.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/48x48/actions/48-actions-account-types_income.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/48x48/actions/48-actions-account-types_investments.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/48x48/actions/48-actions-account-types_liability.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/48x48/actions/48-actions-account-types_loan.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/48x48/actions/48-actions-account-types_savings.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/48x48/actions/48-actions-account_add.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/48x48/actions/48-actions-forcast.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/48x48/actions/48-actions-institution_add.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/48x48/actions/48-actions-institutions.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/48x48/actions/48-actions-investments.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/48x48/actions/48-actions-onlinebanking.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/48x48/actions/48-actions-transaction_find.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/64x64/actions/64-actions-account-types_asset.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/64x64/actions/64-actions-account-types_cash.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/64x64/actions/64-actions-account-types_checking.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/64x64/actions/64-actions-account-types_closed.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/64x64/actions/64-actions-account-types_credit-card.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/64x64/actions/64-actions-account-types_expense.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/64x64/actions/64-actions-account-types_income.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/64x64/actions/64-actions-account-types_investments.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/64x64/actions/64-actions-account-types_liability.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/64x64/actions/64-actions-account-types_loan.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/64x64/actions/64-actions-account-types_savings.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/64x64/actions/64-actions-account_add.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/64x64/actions/64-actions-forcast.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/64x64/actions/64-actions-institution_add.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/64x64/actions/64-actions-institutions.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/64x64/actions/64-actions-investments.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/64x64/actions/64-actions-onlinebanking.png <span style="color: grey">()</span></li>
<li>kmymoney/icons/Tango/64x64/actions/64-actions-transaction_find.png <span style="color: grey">()</span></li>
<li>kmymoney/kmymoney.cpp <span style="color: grey">(550de35)</span></li>
<li>kmymoney/kmymoney.kcfg <span style="color: grey">(4d503f3)</span></li>
<li>kmymoney/kmymoneyutils.h <span style="color: grey">(ab3a5d9)</span></li>
<li>kmymoney/kmymoneyutils.cpp <span style="color: grey">(a8d0992)</span></li>
<li>kmymoney/models/accountsmodel.cpp <span style="color: grey">(b395e16)</span></li>
<li>kmymoney/mymoney/mymoneyaccount.cpp <span style="color: grey">(a9cf7e3)</span></li>
<li>kmymoney/mymoney/mymoneyinstitution.cpp <span style="color: grey">(344bfd0)</span></li>
<li>kmymoney/views/kforecastview.cpp <span style="color: grey">(404a28d)</span></li>
<li>kmymoney/views/kmymoneyview.cpp <span style="color: grey">(8301c66)</span></li>
<li>kmymoney/views/kreportsview.cpp <span style="color: grey">(8d05455)</span></li>
<li>kmymoney/views/kscheduledview.cpp <span style="color: grey">(827ea44)</span></li>
<li>kmymoney/widgets/kmymoneyaccountselector.cpp <span style="color: grey">(eaccb22)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129862/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>