<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129371/">https://git.reviewboard.kde.org/r/129371/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Works for me with gpgme 1.8.0 (Gentoo 1.8.0-r2) and no gpgmepp. I'd love to see this in 4.8.1, but I'll wait for one of the developers to give the "ship it."</p></pre>
<br />
<p>- Jack Ostroff</p>
<br />
<p>On January 1st, 2017, 11:19 p.m. UTC, Andreas Sturmlechner wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Andreas Sturmlechner.</div>
<p style="color: grey;"><i>Updated Jan. 1, 2017, 11:19 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Remove bogus qgpgme include.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">REVIEW: 129371</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Make kdepimlibs optional</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Based on b5de50ccaa1571c4feb0c17ea8016554e3b822d7 from master.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">REVIEW: 129371</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Built successfully (so far only tested with GpgME++ 1.7.1 and without kdepimlibs-4).
Also built fine on a system with Gpgme 1.7.1 (no Gpgmepp bindings) and kdepimlibs-4 installed.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(22515185dcb2bdb6a9027101270ff97d445008b6)</span></li>
<li>kmymoney/dialogs/settings/ksettingsschedules.cpp <span style="color: grey">(da138a7ab138d2f5ef1e8f5b7ad636f9a1964343)</span></li>
<li>kmymoney/kmymoney.cpp <span style="color: grey">(3b3352b7abc83b60fe0e8156d48e7be439fb8964)</span></li>
<li>libkdchart/kdablibfakes/src/KDABLibFakes.h <span style="color: grey">(f47ec24423a2ca61b04a98069351539e738fe572)</span></li>
<li>libkgpgfile/CMakeLists.txt <span style="color: grey">(a41a6a408e3da8769308dae75d4f514aa969dc87)</span></li>
<li>libkgpgfile/kgpgfile.cpp <span style="color: grey">(b1870be92edb833ed30f369e3e0ca0f320fe147b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129371/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>