<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129371/">https://git.reviewboard.kde.org/r/129371/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 11th, 2016, 8:38 p.m. UTC, <b>Marko Käning</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Cool, does this mean, that one won't need kdepimlibs anymore when building KMM? :-)</p></pre>
</blockquote>
<p>On November 11th, 2016, 8:49 p.m. UTC, <b>Andreas Sturmlechner</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes, please give it some testing ;)</p></pre>
</blockquote>
<p>On November 11th, 2016, 8:54 p.m. UTC, <b>Marko Käning</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Can't promise when, but will give KMM4 some testing on OSX/macOS. Thanks for implementing this!</p></pre>
</blockquote>
<p>On November 16th, 2016, 12:21 a.m. UTC, <b>Jack Ostroff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">With gpgme 1.7.1, gpgmepp 16.04.3, and kdepimlibs 4.14.11_pre20160211_r2 (Gentoo version) it fails to find gpgmepp. It says it considered but did not accept /usr/lib64/gpgmepp/GpgmeppConfig.cmake. That belongs to kdepimlibs. Should it have continued looking? I don't want to actually uninstall kdepimlibs until I know I can work without it. Is that possible?</p></pre>
</blockquote>
<p>On November 16th, 2016, 12:33 a.m. UTC, <b>Andreas Sturmlechner</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That's expected, Gpgmepp is only found if you built gpgme-1.7.1[cxx] which is blocking kdepimlibs:4. If the latter is present instead, it will use its QGpgmeConfig.cmake as it has always done (even though only using the gpgmepp part from kdepimlibs).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Take a look at https://github.com/gentoo/gentoo/pull/2667 which adds USE=pim to kmymoney-4.8.0 to toggle between building with gpgme-1.7.1[cxx] or kdepimlibs:4.</p></pre>
</blockquote>
<p>On November 16th, 2016, 1:01 a.m. UTC, <b>Jack Ostroff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ah - I didn't have cxx set. So there is no way for me to test this without unmerging kdepimlibs. I suppose I can do a quickpkg so I can put it back quickly if necessary. Right now I just want to be sure it works. I'm already using a mix of portage ebuilds (main tree, kde overaly, and local modifications) as well as some builds without using portage at all. I mostly keep track of what's what, but I do trip over my own feet on occasion. It will be great when I can get back to all in-tree ebuilds. (Sorry for the Gentoo specific digression.)</p></pre>
</blockquote>
<p>On November 18th, 2016, 11:31 p.m. UTC, <b>Jack Ostroff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">(Gentoo specific problem) I've been struggling with getting gpgme to accept the qt5 and cxx use flags. /usr/portage/base/package.use.mask includes the following three lines:
# Alon Bar-Lev <alonbl@gentoo.org> (23 Sep 2016)
# Mask qt5 until kde ports
app-crypt/gpgme cxx qt5
I don't understand the reasoning and whether or not it's safe to unblock them. Thanks for any explanations.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">[Gentoo excursion] echo "app-crypt/gpgme -cxx -qt5" >> /etc/portage/profile/package.use.mask</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is just a safeguard so that most blockers (against old PIM) are sorted out before >=gpgme-1.7.0 is let loose on the tree. You're safe.</p></pre>
<br />
<p>- Andreas</p>
<br />
<p>On November 10th, 2016, 6:13 p.m. UTC, Andreas Sturmlechner wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Andreas Sturmlechner.</div>
<p style="color: grey;"><i>Updated Nov. 10, 2016, 6:13 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Gives kmymoney-4 some extended life on systems that upgrade to KDE Applications 16.12 and are required to upgrade to kdepimlibs-conflicting GpgME-1.7.0 by the latest version of KDE PIM.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Remove bogus qgpgme include.
Make kdepimlibs optional (based on b5de50ccaa1571c4feb0c17ea8016554e3b822d7 from master)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Built successfully (so far only tested with GpgME++ 1.7.1 and without kdepimlibs-4).
Also built fine on a system with Gpgme 1.7.1 (no Gpgmepp bindings) and kdepimlibs-4 installed.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(22515185dcb2bdb6a9027101270ff97d445008b6)</span></li>
<li>kmymoney/dialogs/settings/ksettingsschedules.cpp <span style="color: grey">(da138a7ab138d2f5ef1e8f5b7ad636f9a1964343)</span></li>
<li>kmymoney/kmymoney.cpp <span style="color: grey">(a4251f031cee280983aa67c55447d3f97865dcbd)</span></li>
<li>libkdchart/kdablibfakes/src/KDABLibFakes.h <span style="color: grey">(f47ec24423a2ca61b04a98069351539e738fe572)</span></li>
<li>libkgpgfile/CMakeLists.txt <span style="color: grey">(a41a6a408e3da8769308dae75d4f514aa969dc87)</span></li>
<li>libkgpgfile/kgpgfile.cpp <span style="color: grey">(b1870be92edb833ed30f369e3e0ca0f320fe147b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129371/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>