<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129265/">https://git.reviewboard.kde.org/r/129265/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 29th, 2016, 7:18 a.m. UTC, <b>Thomas Baumgart</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Does this mean, KMyMoney will not compile encryption support on systems with KF5 versions prior 16.12? If so, please make your change backward compatible (if the new stuff is not found, use the old)</p></pre>
</blockquote>
<p>On October 30th, 2016, 6:23 a.m. UTC, <b>Andreas Sturmlechner</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No, it means it will be independent from KDE Applications releases (there is no KF 16.08/16.12). GpgME 1.7.1 with gpgmepp bindings installs side by side with gpgmepp-16.08.3 thanks to the latter using the kf5 prefix, but it collides with the much older gpgmepp-4 from kdepimlibs-4.</pre>
</blockquote>
<p>On October 30th, 2016, 9:35 a.m. UTC, <b>René J.V. Bertin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You are aware that you (as in "all ye all") have made versioning a mess, one that in addition is being agitated way too frequently, right? :P</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Anyway, it's not difficult at all to avoid the install clash with the kdepimlibs4 headers. Configure and install kdelibs4 with something like <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">-DINCLUDE_INSTALL_DIR=${prefix}/include/KDE4</code> and almost all rebuilt KDE4 software will install their headers into that KDE4 directory too.
It's probably a little bit trickier to avoid inclusion confusion in the compiler, though. For that to be avoided reliably GpgME would have to install all its headers into something like <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">${prefix}/include/gpgme</code> and add that path with the appropriate compiler flag.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This may sound futile and in the long run it ought to be, but anyone following activity on the kdepim-users ML should hardly be able to disagree that there still is a very reasonable desire to keep KDEPIM4 buildable for users who require a reliable email client.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Heh, I just happen to submit the odd patch and claim no responsibility otherwise. ;) I don't think it's a mess though, just takes time to arrive at folks that are not that involved with KDE. That's why I like to keep things clear and precise. However, I don't think it is unreasonable for kmymoney/frameworks to depend on a very recent version of gpgme instead of an applications bundle version that is going to be unmaintained in a few weeks' time.</pre>
<br />
<p>- Andreas</p>
<br />
<p>On October 26th, 2016, 7:57 p.m. UTC, Andreas Sturmlechner wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KMymoney and René J.V. Bertin.</div>
<div>By Andreas Sturmlechner.</div>
<p style="color: grey;"><i>Updated Oct. 26, 2016, 7:57 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Gpgmepp is part of GpgME since 1.7.0.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">REVIEW: 129265</p>
<hr style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: 1px solid #ddd;line-height: inherit;" />
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">See also for reference: https://mail.kde.org/pipermail/release-team/2016-September/009732.html</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(c535faba80db64b0a30fc5fdfb09a7a2590ab8a4)</span></li>
<li>config-kmymoney.h.cmake <span style="color: grey">(f024db61af25e291cde2eef392fe161485c82e5d)</span></li>
<li>kmymoney/main.cpp <span style="color: grey">(694ffa28ae67ad0051b893fbdcf9b7b3624f0525)</span></li>
<li>libkgpgfile/CMakeLists.txt <span style="color: grey">(4e366ceab3c12728276feaaec78319315fb9ea6d)</span></li>
<li>libkgpgfile/kgpgfile.cpp <span style="color: grey">(88aac42de83d28be45ad8d1516bd94eb240ed811)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129265/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>