<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129081/">https://git.reviewboard.kde.org/r/129081/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Łukasz Wojniłowicz.</div>
<p style="color: grey;"><i>Updated Oct. 8, 2016, 8:56 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Submitted with commit aca61e364332dafec06f436a0302ef1f30af34ec by ?ukasz Wojni?owicz to branch master.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">1) renamed redefinedlg.cpp to transactiondlg.cpp,
2) merged RedefineDlgDecl and RedefineDlg,
3) initialize transactiondlg only when it's needed,
4) fit size of transactiondlg to content,
5) connected slotAccepted and slotRejected in ui file,
6) removed redundant variables,
7) displayLine doesn't need to know what it displays,
8) add column headers to transactiondlg,
9) it doesn't matter if transaction type is unrecognised or invalid,</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/plugins/csvimport/CMakeLists.txt <span style="color: grey">(6c57307)</span></li>
<li>kmymoney/plugins/csvimport/csvwizard.cpp <span style="color: grey">(3867cd8)</span></li>
<li>kmymoney/plugins/csvimport/investmentwizardpage.h <span style="color: grey">(574c4b6)</span></li>
<li>kmymoney/plugins/csvimport/investmentwizardpage.cpp <span style="color: grey">(5917e65)</span></li>
<li>kmymoney/plugins/csvimport/redefinedlg.h <span style="color: grey">(9594a90)</span></li>
<li>kmymoney/plugins/csvimport/redefinedlg.cpp <span style="color: grey">(b7ca3f4)</span></li>
<li>kmymoney/plugins/csvimport/redefinedlgdecl.ui <span style="color: grey">(12c6191)</span></li>
<li>kmymoney/plugins/csvimport/transactiondlg.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvimport/transactiondlg.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvimport/transactiondlg.ui <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129081/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>