<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129003/">https://git.reviewboard.kde.org/r/129003/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On Wrzesień 24th, 2016, 10:43 rano CEST, <b>Thomas Baumgart</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/129003/diff/1/?file=477386#file477386line918" style="color: black; font-weight: bold; text-decoration: underline;">kmymoney/plugins/csvimport/investmentwizardpage.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">918</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">strEType</span> <span class="o">=</span> <span class="s">"Invst"</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It will work but uses more runtime. Since the "Something" is a const char * with encoding UTF-8 which gets converted to a UTF-16 QString and then added. Also a temporary QString object is allocated and destroyed after the operation. Using</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">strEType += QStringLiteral("Something");</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">is much faster, as the QStringLiteral is already UTF-16 encoded. The drawback is that it uses twice as much memory, but that does not seem to be a problem here.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Done.
I also used QChar with QLatin1Char where appropriate, because it's probably the same kind of problem.
Is it OK now?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">BTW. Thanks form making me aware of UTF8->UTF16 thing :)</p></pre>
<br />
<p>- Łukasz</p>
<br />
<p>On Wrzesień 23rd, 2016, 5:09 po południu CEST, Łukasz Wojniłowicz wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Łukasz Wojniłowicz.</div>
<p style="color: grey;"><i>Updated Wrz 23, 2016, 5:09 po południu</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">csvwizard.cpp has many lines of code, so it's good to separate
investment page from it. The outcome is:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">1) m_pageInvestment is initialized only when it's needed,
2) combo boxes on m_pageInvestment are initialized only when needed,
3) removed registered fields, because there is no need to use them on
other pages,
4) merged investprocessing with investmentwizardpage, so there is no
ping-pong communication between them
5) used only one slot for every combo box,
6) removed name and security filter lineedits, because they aren't
essential/usefull to import,
7) removed redundant includes,
8) clear button causes fees also to be cleared,
9) clear fee column right before user goes back to rows page,
10) changed operation lists initialization to facilitate translation,
11) don't update window size if m_pageInvestment isn't visible, because
it won't work correctly,
12) tidied up names and structure of investmentwizardpage.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/plugins/csvimport/CMakeLists.txt <span style="color: grey">(04664f3)</span></li>
<li>kmymoney/plugins/csvimport/csvimporterplugin.h <span style="color: grey">(847d5b8)</span></li>
<li>kmymoney/plugins/csvimport/csvimporterplugin.cpp <span style="color: grey">(c4478f4)</span></li>
<li>kmymoney/plugins/csvimport/csvwizard.h <span style="color: grey">(1c75de6)</span></li>
<li>kmymoney/plugins/csvimport/csvwizard.cpp <span style="color: grey">(db6e571)</span></li>
<li>kmymoney/plugins/csvimport/investmentwizardpage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvimport/investmentwizardpage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvimport/investmentwizardpage.ui <span style="color: grey">(3b4d6a2)</span></li>
<li>kmymoney/plugins/csvimport/investprocessing.h <span style="color: grey">(87b5512)</span></li>
<li>kmymoney/plugins/csvimport/investprocessing.cpp <span style="color: grey">(860ca77)</span></li>
<li>kmymoney/plugins/csvimport/redefinedlg.h <span style="color: grey">(688725e)</span></li>
<li>kmymoney/plugins/csvimport/redefinedlg.cpp <span style="color: grey">(58fa625)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129003/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>