<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129014/">https://git.reviewboard.kde.org/r/129014/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/129014/diff/1/?file=477461#file477461line93" style="color: black; font-weight: bold; text-decoration: underline;">kmymoney/plugins/csvimport/bankingwizardpage.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">93</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ui</span><span class="o">-></span><span class="n">comboBoxBnk_numberCol</span><span class="o">-></span><span class="n">clear</span><span class="p">();</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'd play with the findChildren<QComboBox*>() here to run this in a loop and doing the clear() and addItems() call inside the loop while having the columnNumbers stringlist set up before. See http://doc.qt.io/qt-5/qobject.html#findChildren for more details.</p></pre>
</div>
</div>
<br />
<p>- Thomas Baumgart</p>
<br />
<p>On September 25th, 2016, 3:50 nachm. CEST, Łukasz Wojniłowicz wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Łukasz Wojniłowicz.</div>
<p style="color: grey;"><i>Updated Sept. 25, 2016, 3:50 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">csvwizard.cpp has many lines of code, so it's good to separate banking
page from it. The outcome is:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">1) m_pageBanking is initialized only when it's needed,
2) combo boxes on m_pageBanking are initialized only when needed,
3) removed registered fields, because there is no need to use them on
other pages,
4) merged csvdialog with bankingwizardpage, so there is no ping-pong
communication between them,
5) used only one slot for every combo box,
6) removed redundant includes,
7) tidied up names and structure of investmentwizardpage.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/plugins/csvimport/CMakeLists.txt <span style="color: grey">(46cdc16)</span></li>
<li>kmymoney/plugins/csvimport/bankingwizardpage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvimport/bankingwizardpage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvimport/csvdialog.h <span style="color: grey">(d1e935c)</span></li>
<li>kmymoney/plugins/csvimport/csvdialog.cpp <span style="color: grey">(9385d9b)</span></li>
<li>kmymoney/plugins/csvimport/csvimporterplugin.h <span style="color: grey">(e2908e4)</span></li>
<li>kmymoney/plugins/csvimport/csvutil.h <span style="color: grey">(108718e)</span></li>
<li>kmymoney/plugins/csvimport/csvwizard.h <span style="color: grey">(6fbb858)</span></li>
<li>kmymoney/plugins/csvimport/csvwizard.cpp <span style="color: grey">(7f59af7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129014/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>